-
Notifications
You must be signed in to change notification settings - Fork 66
Improve security of remote app connections #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This demonstrates better practice and makes it less likely users will copy the keys directly
|
Why force hexadecimal GUIDs? You could shave a lot of extra bytes on the wire by choosing more compact representations using higher-base encodings, while keeping the same amount of entropy. If the goal is to enforce 128 bits of entropy, could you have a low-level |
|
@khellang yea, there are a lot of options here. I prefer a string over a byte[] since that makes it easier to read from some config sources. And we could just say "string with minimum 12 characters" or something like that, but forcing the characters to be hex digits makes it less likely users will choose a "bad" password. I'll re-work this given @twsouthwick's recent changes so that it just validates with a regex data annotation looking for 32 hex characters (with or without dashes or parentheses). |
# Conflicts: # samples/MvcApp/Web.config # src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/RemoteAppClientExtensions.cs # src/Microsoft.AspNetCore.SystemWebAdapters.CoreServices/RemoteAppClientOptions.cs # src/Microsoft.AspNetCore.SystemWebAdapters.FrameworkServices/RemoteAppServerExtensions.cs
This helps to ensure users are choosing strong API keys by requiring them to be parsable as GUIDs. Also updates docs to explain the API key requirements and recommend HTTPS for the ASP.NET app to ensure the ASP.NET Core app can request data from it in production scenarios securely.
Fixes #144