Skip to content

Conversation

@sdekock
Copy link
Contributor

@sdekock sdekock commented Aug 12, 2022

Issue #142

Add implicit cast operators for HttpContextBase, HttpRequestBase, HttpResponseBase from and to the equivalent ASP.NET Core types.

@dnfadmin
Copy link

dnfadmin commented Aug 12, 2022

CLA assistant check
All CLA requirements met.

@twsouthwick
Copy link
Member

@sdekock I'm fine with the implicit operators to convert to the adapters (the absence of those here is probably an oversight). Would be great to get this into the next release if you can remove the other stuff.

@sdekock sdekock force-pushed the sdk/base-implicit-casts branch from 46caabe to db93e6a Compare August 24, 2022 18:07
Copy link
Member

@twsouthwick twsouthwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @sdekock

@sdekock sdekock force-pushed the sdk/base-implicit-casts branch from d5d6af2 to c980ca6 Compare August 24, 2022 18:12
@twsouthwick twsouthwick merged commit 32a8717 into dotnet:main Aug 24, 2022
@sdekock sdekock deleted the sdk/base-implicit-casts branch August 25, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants