Rework configuring timeout on remote app API #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in session state project
twsouthwick
approved these changes
Aug 9, 2022
Member
twsouthwick
left a comment
twsouthwick
left a comment
There was a problem hiding this comment.
LGTM! I like how it simplifies a few things. I've got a few questions but nothing blocking
src/Microsoft.AspNetCore.SystemWebAdapters/Adapters/RemoteAppOptions.Shared.cs
Outdated
Show resolved
Hide resolved
...osoft.AspNetCore.SystemWebAdapters/Adapters/Authentication/RemoteAppAuthenticationService.cs
Show resolved
Hide resolved
src/Microsoft.AspNetCore.SystemWebAdapters/Adapters/RemoteAppOptions.Shared.cs
Show resolved
Hide resolved
...soft.AspNetCore.SystemWebAdapters.SessionState/RemoteSession/RemoteAppSessionStateManager.cs
Show resolved
Hide resolved
...soft.AspNetCore.SystemWebAdapters.SessionState/RemoteSession/RemoteAppSessionStateManager.cs
Outdated
Show resolved
Hide resolved
…ptions.Shared.cs Co-authored-by: Taylor Southwick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
NetworkTimeoutwith the ability to just provide anHttpClientas per API review. Also fixed an issue with paths on configured base URLs getting dropped.Fixes #133
Fixes #138