Skip to content

Ensure SyncRoot is not null #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2022
Merged

Ensure SyncRoot is not null #132

merged 3 commits into from
Jul 28, 2022

Conversation

@twsouthwick
Copy link
Member

No description provided.

@twsouthwick twsouthwick requested a review from mjrousos July 27, 2022 01:30
mjrousos
mjrousos reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@mjrousos mjrousos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, though just creating a new object also would work and it seems we've used that approach in the past.

What I'm more curious about is why we need this API implemented at all. How is it being used?

@twsouthwick
Copy link
Member Author

What I'm more curious about is why we need this API implemented at all. How is it being used?

Solely because HttpContext.Items is non generic and this is part of the API. If someone is using the API, it should be implemented since it's on the contract there.

@twsouthwick twsouthwick requested a review from mjrousos July 28, 2022 17:14
mjrousos
mjrousos approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@mjrousos mjrousos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twsouthwick twsouthwick merged commit b40adf2 into main Jul 28, 2022
@twsouthwick twsouthwick deleted the sync-root branch July 28, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjrousos mjrousos mjrousos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twsouthwick @mjrousos