This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
Prevent non-framework code from extending BaseNumberConverter #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairernovotny
approved these changes
May 2, 2019
jkotas
approved these changes
May 3, 2019
jaredpar
approved these changes
May 3, 2019
marek-safar
approved these changes
May 3, 2019
stephentoub
approved these changes
May 3, 2019
|
@joshpeterson @JonathanHUnity any objections? |
|
@joshpeterson @JonathanHUnity friendly ping :-) |
|
@Anipik actually discovered more of these that should be rolled into this change dotnet/corefx@28a926b |
joshpeterson
approved these changes
May 9, 2019
This was referenced May 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1171.
Please note that this is technically an API breaking change (we shipped
BaseNumberConverterin .NET Standard 2.0 with a protected constructor, which was mistake). But there is no way to derive and instantiate this class. An exception will get thrown if you try to instantiate the derived class.For more details, see dotnet/corefx#37278.
/cc @ericstj