Skip to content

Source (.) init-tools.sh rather than executing it #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2017
Merged

Source (.) init-tools.sh rather than executing it #240

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a897dba
Source (.) init-tools.sh rather than executing it
dagood Oct 16, 2017
ef41642
Unset eu, pipefail: init-tools.sh not compatible
dagood Oct 16, 2017
59dc793
Fix init-tools.sh to work with -euo pipefail
dagood Oct 16, 2017
3d340c1
Use "source" rather than "." for readability
dagood Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ export DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
export DOTNET_MULTILEVEL_LOOKUP=0
export NUGET_PACKAGES="$SCRIPT_ROOT/packages/"

"$SCRIPT_ROOT/init-tools.sh"
(
# init-tools.sh isn't compatible with these flags. Unset them in this subshell.
set +euo pipefail
Copy link
Member Author

@dagood dagood Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed and I had to add this workaround, still look ok @weshaggard?

Copy link
Member

@weshaggard weshaggard Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix init-tools so it works with this option? What was the failure?

Copy link
Member Author

@dagood dagood Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first error is:

init-tools.sh: line 9: __BUILDTOOLS_SOURCE: unbound variable

I'll give fixing it a try (waiting for a different build to finish).

Copy link
Member

@weshaggard weshaggard Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just remove the "u" option in the root script.

Copy link
Member Author

@dagood dagood Oct 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I really like how -u forces scripts to be clear if they expect the variable to be set at that point in time, and I think it's worth keeping. I haven't done a ton of work with it yet, though.

. "$SCRIPT_ROOT/init-tools.sh"
)

CLIPATH="$SCRIPT_ROOT/Tools/dotnetcli"
SDKPATH="$CLIPATH/sdk/$SDK_VERSION"
Expand Down