Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dotnet/runtime 5.0 targeting pack build #1703

Closed
dagood opened this issue Aug 12, 2020 · 1 comment
Closed

Disable dotnet/runtime 5.0 targeting pack build #1703

dagood opened this issue Aug 12, 2020 · 1 comment
Labels
area-product-experience Improvements in the end-user's product experience

Comments

@dagood
Copy link
Member

dagood commented Aug 12, 2020

We need to make sure the 5.0.0 targeting packs don't build and are generated in SBRP, if dotnet/runtime#1622 isn't completed in 5.0. The work to disable it might already be done but I'm not sure, filing this as a tracking issue for source-build functionality.

I wasn't able to find anything doing this in the current master branch, any ideas @crummel @dseefeld, or is this something that we know isn't done based on the current 5.0 WIP builds?

On the runtime side, @NikolaMilosavljevic could implement this disable in dotnet/runtime, or @jkoritzinsky may get the new sharedfx tooling in and obviate all of this.

(Related: dotnet/runtime#32982, where in triage I thought we had already patched this.)

@dagood dagood added area-product-experience Improvements in the end-user's product experience triaged labels Aug 12, 2020
@dagood
Copy link
Member Author

dagood commented Nov 24, 2020

We have Microsoft.NETCore.App.Ref,5.0.0 in the prebuilt list, which is pretty good evidence we have done this for the 5.0.0 GA build.

@dagood dagood closed this as completed Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-product-experience Improvements in the end-user's product experience
Projects
None yet
Development

No branches or pull requests

1 participant