Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable targeting pack build during source-build: avoid incomplete platform manifest #32982

Closed
dagood opened this issue Feb 28, 2020 · 1 comment · Fixed by #40870
Closed

Disable targeting pack build during source-build: avoid incomplete platform manifest #32982

dagood opened this issue Feb 28, 2020 · 1 comment · Fixed by #40870
Assignees
@NikolaMilosavljevic
Labels
area-Infrastructure-installer
Milestone
5.0.0

Comments

@dagood
Copy link
Member

dagood commented Feb 28, 2020

See #1622 for the reason why the targeting pack is incomplete, and a plan to make it complete.

If that's not addressed by 5.0, we should disable targeting pack generation during source-build. This allows source-build to decompile the targeting pack (as usual) and use it as the 5.0.0 targeting pack. If we don't disable it, we risk having dotnet/runtime building an incomplete 5.0.0 targeting pack that ends up in the source-built .NET Core SDK.

The overall effort to create targeting packs "properly" in the dotnet/runtime repo is tracked by dotnet/source-build#1523.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 28, 2020
@dagood dagood mentioned this issue Feb 28, 2020
Closed
@NikolaMilosavljevic NikolaMilosavljevic removed the untriaged New issue has not been triaged by the area owner label Mar 11, 2020
@NikolaMilosavljevic NikolaMilosavljevic self-assigned this Mar 11, 2020
@NikolaMilosavljevic NikolaMilosavljevic added this to the 5.0 milestone Mar 11, 2020
@dagood dagood mentioned this issue May 7, 2020
Closed
@NikolaMilosavljevic
Copy link
Member

There's a patch in source-build that could be incorporated in runtime repo.

@dagood dagood mentioned this issue Aug 12, 2020
Closed
@NikolaMilosavljevic NikolaMilosavljevic mentioned this issue Aug 15, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NikolaMilosavljevic NikolaMilosavljevic

Labels
area-Infrastructure-installer
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Do not build Targeting pack in source-build NikolaMilosavljevic/runtime
3 participants
@NikolaMilosavljevic @dagood @Dotnet-GitSync-Bot