Skip to content

Conversation

@zivkan
Copy link
Member

@zivkan zivkan commented Nov 27, 2025

Source build update for dotnet/sdk#51933

Add wcwsith.sources version 4.0.1
Update spectre-console's patch
@zivkan zivkan requested a review from a team as a code owner November 27, 2025 00:29
@zivkan zivkan changed the base branch from main to release/10.0 November 27, 2025 00:30
@zivkan zivkan changed the base branch from release/10.0 to main November 27, 2025 00:31
@MichaelSimons
Copy link
Member

FYI, I removed wcwidth.souces 3.0.0 which appears to have been only referenced by the previous spectre.console version. Removing unreferenced packages is a hygiene thing that also helps with build times.

@MichaelSimons MichaelSimons merged commit feab92a into dotnet:main Dec 1, 2025
4 checks passed
@MichaelSimons
Copy link
Member

@zivkan, What branch is this going to be consumed in? Does it need to be backported to 10? That will have to be manually backported as spectre.console doesn't exist in 10 yet.

zivkan added a commit to zivkan/source-build-reference-packages that referenced this pull request Dec 1, 2025
* Upgrade Spectre.Console to 0.54.0

* Make build work

Add wcwsith.sources version 4.0.1
Update spectre-console's patch

* Remove wcwidth.sources which was upgraded to 4.0.1

---------

Co-authored-by: Michael Simons <[email protected]>
@zivkan
Copy link
Member Author

zivkan commented Dec 1, 2025

I cherry-picked the two commits into a PR on the release/10.0 branch:

MichaelSimons added a commit that referenced this pull request Dec 1, 2025
* Add Spectre.Console 0.52.0 (#1447)

* Add Spectre.Console 0.52.0 (#1287)

Context: #1287

* Update spectre-console submodule to 0.52.0

* Add patch file to delete problematic binaries:

#1287 (comment)

Co-authored-by: Jan Jones <[email protected]>

* Remove binary patch again

* Pin darc version

* Add DelaySign and PublicSign to build arguments

---------

Co-authored-by: Jan Jones <[email protected]>
Co-authored-by: Premek Vysoky <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>

* Update spectre.console (#1482)

* Upgrade Spectre.Console to 0.54.0

* Make build work

Add wcwsith.sources version 4.0.1
Update spectre-console's patch

* Remove wcwidth.sources which was upgraded to 4.0.1

---------

Co-authored-by: Michael Simons <[email protected]>

---------

Co-authored-by: Jonathan Peppers <[email protected]>
Co-authored-by: Jan Jones <[email protected]>
Co-authored-by: Premek Vysoky <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: Michael Simons <[email protected]>
MichaelSimons added a commit to dotnet/dotnet that referenced this pull request Dec 9, 2025
MichaelSimons added a commit to dotnet/dotnet that referenced this pull request Dec 9, 2025
dotnet-maestro bot added a commit to dotnet/dotnet that referenced this pull request Dec 10, 2025
[release/10.0.1xx] Source code updates from nuget/nuget.client


 - Sign spectre.console with 3p cert

 - Merge remote-tracking branch 'upstream/release/10.0.1xx' into darc-release/10.0.1xx-7db7ce8f-5a7b-4b95-8467-49ba13688a32

 - Update SpectreConsoleReleaseVersion to 0.54.0

Missed version update in dotnet/source-build-reference-packages#1482
ViktorHofer pushed a commit to dotnet/dotnet that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants