Skip to content

Use release version of Spectre.Console #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mthalman merged 2 commits into from
Jul 8, 2025
Merged

Use release version of Spectre.Console #1291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d37604
Use release version of Spectre.Console
jjonescz Jul 8, 2025
6c7c6e0
Use property for the version
jjonescz Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
<HumanizerReleaseVersion>2.14.1</HumanizerReleaseVersion>
<MSBuildLocatorReleaseVersion>1.6.10</MSBuildLocatorReleaseVersion>
<SolutionPersistenceVersion>1.0.52</SolutionPersistenceVersion>
<SpectreConsoleReleaseVersion>0.48.0</SpectreConsoleReleaseVersion>
<XunitReleaseVersion>2.9.2</XunitReleaseVersion>
</PropertyGroup>
<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/externalPackages/projects/spectre-console.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<BuildCommandArgs>$(BuildCommandArgs) /p:Configuration=$(Configuration)</BuildCommandArgs>
<BuildCommandArgs>$(BuildCommandArgs) /v:$(LogVerbosity)</BuildCommandArgs>
<BuildCommandArgs>$(BuildCommandArgs) $(RedirectRepoOutputToLog)</BuildCommandArgs>
<BuildCommandArgs>$(BuildCommandArgs) /p:Version=$(SpectreConsoleReleaseVersion)</BuildCommandArgs>
<BuildCommandArgs>$(BuildCommandArgs) /p:Version=0.50.0</BuildCommandArgs>

@mthalman mthalman Jul 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with moving the version out of Versions.props. But can you preserve the original SpectreConsoleReleaseVersion and define it up towards the top of this file so that it can be easily found?

<BuildCommandArgs>$(BuildCommandArgs) /p:TargetFrameworks=$(NetCurrent)</BuildCommandArgs>
<BuildCommandArgs>$(BuildCommandArgs) /p:UseBuildTimeTools=false</BuildCommandArgs>
<BuildCommandArgs>$(BuildCommandArgs) /p:IsAotCompatible=false</BuildCommandArgs>
Expand Down
2 changes: 1 addition & 1 deletion src/externalPackages/src/spectre-console
Open in desktop
Submodule spectre-console updated 41 files
+1 −1 docs/Docs.csproj
+0 −2 docs/input/assets/casts/align-rich.cast
+0 −71 docs/input/blog/posts/2025-04-08-spectre-console-0.50-released.md
+0 −84 docs/input/cli/unit-testing.md
+0 −66 docs/input/widgets/align.md
+0 −7 docs/input/widgets/table.md
+2 −2 resources/scripts/Generator/Generator.csproj
+4 −4 src/Directory.Packages.props
+1 −1 src/Spectre.Console.Cli/Annotations/CommandArgumentAttribute.cs
+1 −8 src/Spectre.Console.Cli/Annotations/CommandOptionAttribute.cs
+0 −10 src/Spectre.Console.Cli/CommandRuntimeException.cs
+28 −65 src/Spectre.Console.Cli/Help/HelpProvider.cs
+3 −8 src/Spectre.Console.Cli/Help/HelpProviderStyles.cs
+1 −1 src/Spectre.Console.Cli/Help/ICommandParameter.cs
+1 −1 src/Spectre.Console.Cli/Internal/CommandExecutor.cs
+1 −3 src/Spectre.Console.Cli/Internal/CommandValidator.cs
+1 −1 src/Spectre.Console.Cli/Internal/Commands/ExplainCommand.cs
+2 −2 src/Spectre.Console.Cli/Internal/Commands/XmlDocCommand.cs
+3 −3 src/Spectre.Console.Cli/Internal/Configuration/TemplateParser.cs
+1 −1 src/Spectre.Console.Cli/Internal/Modelling/CommandModelValidator.cs
+2 −3 src/Spectre.Console.Cli/Internal/Modelling/CommandOption.cs
+2 −2 src/Spectre.Console.Cli/Internal/Modelling/CommandParameter.cs
+11 −18 src/Spectre.Console.Testing/Cli/CommandAppTester.cs
+2 −28 src/Spectre.Console/Internal/Cell.cs
+2 −1 src/Spectre.Console/Live/LiveDisplayRenderer.cs
+1 −9 src/Spectre.Console/Live/LiveRenderable.cs
+1 −1 src/Spectre.Console/Live/Progress/Renderers/DefaultProgressRenderer.cs
+1 −1 src/Spectre.Console/Prompts/List/ListPromptRenderHook.cs
+1 −1 src/Spectre.Console/Spectre.Console.csproj
+0 −5 src/Spectre.Console/Style.cs
+1 −1 src/Spectre.Console/Widgets/Exceptions/ExceptionFormatter.cs
+0 −14 src/Tests/Spectre.Console.Cli.Tests/Data/Settings/RequiredOptionsSettings.cs
+0 −6 src/Tests/Spectre.Console.Cli.Tests/Expectations/Help/Required_Options.Output.verified.txt
+0 −6 src/Tests/Spectre.Console.Cli.Tests/Expectations/Help/Required_Options_No_Description.Output.verified.txt
+0 −38 src/Tests/Spectre.Console.Cli.Tests/Unit/CommandAppTests.Help.cs
+0 −27 src/Tests/Spectre.Console.Cli.Tests/Unit/CommandAppTests.Options.cs
+1 −1 src/Tests/Spectre.Console.Cli.Tests/Unit/CommandAppTests.Sensitivity.cs
+0 −36 src/Tests/Spectre.Console.Cli.Tests/Unit/Testing/CommandAppTesterTests.cs
+0 −80 src/Tests/Spectre.Console.Cli.Tests/Unit/Testing/InteractiveCommandTests.cs
+0 −17 src/Tests/Spectre.Console.Tests/Unit/AnsiConsoleTests.cs
+0 −26 src/Tests/Spectre.Console.Tests/Unit/StyleTests.cs