Use release version of Spectre.Console - #1291
Merged
Merged
Conversation
jjonescz
marked this pull request as ready for review
July 8, 2025 17:12
mthalman
reviewed
Jul 8, 2025
| <BuildCommandArgs>$(BuildCommandArgs) /v:$(LogVerbosity)</BuildCommandArgs> | ||
| <BuildCommandArgs>$(BuildCommandArgs) $(RedirectRepoOutputToLog)</BuildCommandArgs> | ||
| <BuildCommandArgs>$(BuildCommandArgs) /p:Version=$(SpectreConsoleReleaseVersion)</BuildCommandArgs> | ||
| <BuildCommandArgs>$(BuildCommandArgs) /p:Version=0.50.0</BuildCommandArgs> |
Member
There was a problem hiding this comment.
I'm fine with moving the version out of Versions.props. But can you preserve the original SpectreConsoleReleaseVersion and define it up towards the top of this file so that it can be easily found?
mthalman
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #1287.
Without this PR, the spectre-console submodule is based on
main(which is a prerelease) and the version number was outdated (wasn't removed with the rest of the submodule so I missed updating it when reverting the removal).In this PR, I've checked out version 0.50.0 in the submodule and used the corresponding version number when building the package.