Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc project cleanup #115

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Misc project cleanup #115

merged 6 commits into from
Mar 10, 2023

Conversation

MichaelSimons
Copy link
Member

The following cleanup changes were made.

  1. Rename the repo project to repo-projects to align with the VMR directory structure
  2. Removed the unused RepoApiImplemented properties
  3. Removed the unused RepositoryName override capability. This is needed as part of Add VMR sync functionality into dotnet/dotnet's Codespaces installer#15750 (comment)
  4. Cleanup the netcorecli-fsc and newtonsoft-json projects. There were some redundant build args being passed and some long lines that were hard to read pending your editor.
  5. Removed the DeterministicBuildOptOutProperty as every repo was specifying it except netcorecli-fsc which from my assessment doesn't matter since that repo has no binaries in the resulting package. If it did, it likely needs this property set.

I made separate commits for each of this to make reviewing the changes easier.

@MichaelSimons MichaelSimons requested a review from a team March 10, 2023 18:03
@MichaelSimons
Copy link
Member Author

cc @premun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants