[release/10.0] Source code updates from dotnet/dotnet - #1767
Conversation
Diff: https://github.com/dotnet/dotnet/compare/aab2258c273446c41cf7cf71124be422d56a290a..6f10c96a0e287ab72085d23161056c05d56eb0e3 From: dotnet/dotnet@aab2258 To: dotnet/dotnet@6f10c96 [[ commit created by automation ]]
Updated Dependencies: Microsoft.Build, Microsoft.Build.Utilities.Core (Version 18.0.11 -> 18.0.11) Microsoft.DotNet.Arcade.Sdk (Version 10.0.0-beta.26403.103 -> 10.0.0-beta.26411.108) Microsoft.DotNet.GenAPI.Task (Version 10.0.112-servicing.26403.103 -> 10.0.112-servicing.26411.108) Microsoft.NETCore.ILAsm, Microsoft.NETCore.ILDAsm (Version 10.0.12 -> 10.0.12) Added Dependencies: Microsoft.Bcl.Cryptography (Version 10.0.12) [[ commit created by automation ]]
|
Note VMR PRs included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Updated Dependencies: Microsoft.Bcl.Cryptography, Microsoft.NETCore.ILAsm, Microsoft.NETCore.ILDAsm (Version 10.0.12 -> 10.0.12) Microsoft.Build, Microsoft.Build.Utilities.Core (Version 18.0.11 -> 18.0.11) Microsoft.DotNet.Arcade.Sdk (Version 10.0.0-beta.26411.108 -> 10.0.0-beta.26412.103) Microsoft.DotNet.GenAPI.Task (Version 10.0.112-servicing.26411.108 -> 10.0.112-servicing.26412.103) [[ commit created by automation ]]
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
@mthalman It looks like this is the same fix that I originally had for dotnet/dotnet#8281. Is that the right fix? It should be obvious I don't really know what I'm doing here, but based on @mmitche's feedback on my PR copilot updated it to switch to source build reference packages. Is that a better solution? |
|
SBRP can't be used here since the dependency is a 10.0 package. We can't have 10.0 packages in the 10.0 version of SBRP. |
|
@dsplaisted - Needs another reviewer |
|
Okay I gotcha. This is an oddity where we have a 10.0 reference. The rest of the deps in this package are pre-10.0, so we need to resolve from PSB. Except in isoalted builds, we have no PSB so we just resolve from the normal package feeds? |
|
Interestingly..this might be one place where a 10.0 reference package in a 10.0 branch might be reasonable (if there is no implementation redisted) |
Note
This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
New Dependencies
Updated Dependencies
Associated changes in source repos
Diff the source with this PR branch