Skip to content

Move eight P0/P1 skills to staging #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
y87feng wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Move eight P0/P1 skills to staging #972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8caa01
remove
y87feng Jul 30, 2026
28ef504
adjust metadata
y87feng Jul 30, 2026
bdaaa3b
Keep dotnet-blazor skills on main
y87feng Jul 30, 2026
70e0f1e
Keep microbenchmarking on main
y87feng Jul 30, 2026
9ff288c
Remove stale MAUI eval exemptions
y87feng Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 0 additions & 10 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@
/plugins/dotnet-upgrade/skills/migrate-nullable-references/ @agocke @dotnet/skills-upgrade-reviewers
/tests/dotnet-upgrade/migrate-nullable-references/ @agocke @dotnet/skills-upgrade-reviewers

/plugins/dotnet-upgrade/skills/dotnet-aot-compat/ @agocke @dotnet/appmodel @dotnet/skills-upgrade-reviewers
/tests/dotnet-upgrade/dotnet-aot-compat/ @agocke @dotnet/appmodel @dotnet/skills-upgrade-reviewers

/plugins/dotnet-upgrade/skills/migrate-dotnet9-to-dotnet10/ @dotnet/compat
/tests/dotnet-upgrade/migrate-dotnet9-to-dotnet10/ @dotnet/compat
/plugins/dotnet-upgrade/skills/migrate-dotnet10-to-dotnet11/ @dotnet/compat
/tests/dotnet-upgrade/migrate-dotnet10-to-dotnet11/ @dotnet/compat
/plugins/dotnet-upgrade/skills/migrate-dotnet8-to-dotnet9/ @dotnet/compat
Expand All @@ -51,9 +46,6 @@
/plugins/dotnet-diag/skills/dotnet-trace-collect/ @brianrob @noahfalk @dotnet/skills-diag-reviewers
/tests/dotnet-diag/dotnet-trace-collect/ @brianrob @noahfalk @dotnet/skills-diag-reviewers

/plugins/dotnet-diag/skills/android-tombstone-symbolication/ @dotnet/dotnet-diag @dotnet/skills-diag-reviewers
/tests/dotnet-diag/android-tombstone-symbolication/ @dotnet/dotnet-diag @dotnet/skills-diag-reviewers

/plugins/dotnet-diag/skills/apple-crash-symbolication/ @dotnet/dotnet-diag @dotnet/skills-diag-reviewers
/tests/dotnet-diag/apple-crash-symbolication/ @dotnet/dotnet-diag @dotnet/skills-diag-reviewers

Expand Down Expand Up @@ -117,8 +109,6 @@
/tests/dotnet-maui/maui-app-lifecycle/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
/plugins/dotnet-maui/skills/maui-dependency-injection/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
/tests/dotnet-maui/maui-dependency-injection/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
/plugins/dotnet-maui/skills/maui-collectionview/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
/tests/dotnet-maui/maui-collectionview/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
/plugins/dotnet-maui/skills/maui-data-binding/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
/tests/dotnet-maui/maui-data-binding/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
/plugins/dotnet-maui/skills/maui-safe-area/ @davidortinau @Redth @jfversluis @dotnet/skills-maui-reviewers
Expand Down
4 changes: 0 additions & 4 deletions eng/allowed-external-deps.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@
# To get clean, remove entries as the underlying dependency is resolved.
# Once this file is empty and all checks pass, the checks can be promoted to hard errors.

# dotnet-diag plugin: android-tombstone-symbolication skill
script:android-tombstone-symbolication:scripts/Symbolicate-Tombstone.ps1
invokes:android-tombstone-symbolication

# dotnet-upgrade plugin: migrate-nullable-references skill
script:migrate-nullable-references:scripts/Get-NullableReadiness.ps1

Expand Down
6 changes: 3 additions & 3 deletions eng/dashboard/generate-token-data.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ $plugins = [ordered]@{
"dotnet" = @("csharp-scripts", "dotnet-pinvoke", "nuget-trusted-publishing")
"dotnet-ai" = @("technology-selection")
"dotnet-data" = @("optimizing-ef-core-queries")
"dotnet-diag" = @("analyzing-dotnet-performance", "android-tombstone-symbolication", "dotnet-trace-collect", "dump-collect", "microbenchmarking")
"dotnet-diag" = @("analyzing-dotnet-performance", "dotnet-trace-collect", "dump-collect", "microbenchmarking")
"dotnet-maui" = @("dotnet-maui-doctor")
"dotnet-msbuild" = @("binlog-failure-analysis", "build-parallelism", "build-perf-diagnostics", "incremental-build", "msbuild-antipatterns", "msbuild-modernization")
"dotnet-msbuild" = @("binlog-failure-analysis", "build-parallelism", "build-perf-diagnostics", "incremental-build", "msbuild-modernization")

@AbhitejJohn AbhitejJohn Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling all of this together, folks — the config cleanup itself is clean (I checked all four modified files and there are no leftover entries for the eight skills).

One gap though: we drop msbuild-antipatterns (and eval-performance / check-bin-obj-clash) here, but several retained msbuild artifacts still point at them. A few concrete ones:

  • plugins/dotnet-msbuild/agents/msbuild-code-review.agent.md:53 has a hard markdown link [msbuild-antipatterns skill](../skills/msbuild-antipatterns/SKILL.md) — that target is deleted, so it's now a dead link.
  • msbuild.agent.md and build-perf.agent.md still advertise eval-performance / msbuild-antipatterns / check-bin-obj-clash in their "available skills" lists, and the review agent leans on msbuild-antipatterns AP-13/AP-14/AP-21 by name.

Since these agents ship on main, they'll route the model to skills that no longer exist. The PR's "Reference scan: 0 errors" line only covers external URLs (that's all ReferenceScanner.cs checks), so it wouldn't catch any of this. Could we scrub or soften the inbound references in the same change? Happy to send a small pass against the branch if that helps.

(Copilot, commenting on Abhitej's behalf.)

"dotnet-test" = @("migrate-vstest-to-mtp", "run-tests", "writing-mstest-tests")
"dotnet-upgrade" = @("dotnet-aot-compat", "migrate-dotnet9-to-dotnet10", "migrate-nullable-references")
"dotnet-upgrade" = @("migrate-nullable-references")

@AbhitejJohn AbhitejJohn Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same inbound-reference nit on the upgrade side: plugins/dotnet-upgrade/skills/migrate-dotnet8-to-dotnet9/SKILL.md:30 still tells users to "use the migrate-dotnet9-to-dotnet10 skill as the next step", which we're removing here — so that hand-off now dead-ends on main. Curious whether we want to update it to point at migrate-dotnet10-to-dotnet11 or just drop the pointer while the skill is on staging.

(Copilot, commenting on Abhitej's behalf.)

}

$random = [System.Random]::new(42) # Fixed seed for reproducibility
Expand Down
8 changes: 0 additions & 8 deletions eng/eval-quality/underpowered-allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,13 @@ tests/dotnet-msbuild/binlog-failure-analysis/eval.yaml
tests/dotnet-msbuild/build-parallelism/eval.yaml
tests/dotnet-msbuild/build-perf-baseline/eval.yaml
tests/dotnet-msbuild/build-perf-diagnostics/eval.yaml
tests/dotnet-msbuild/check-bin-obj-clash/eval.yaml
tests/dotnet-msbuild/directory-build-organization/eval.yaml
tests/dotnet-msbuild/eval-performance/eval.yaml
tests/dotnet-msbuild/including-generated-files/eval.yaml
tests/dotnet-msbuild/incremental-build/eval.yaml
tests/dotnet-msbuild/msbuild-modernization/eval.yaml
tests/dotnet-msbuild/msbuild-server/eval.yaml
tests/dotnet-msbuild/resolve-project-references/eval.yaml
tests/dotnet-template-engine/template-instantiation/eval.yaml
tests/dotnet-upgrade/dotnet-aot-compat/eval.yaml
tests/dotnet-advanced/dotnet-pinvoke/eval.yaml
tests/dotnet-blazor/collect-user-input/eval.yaml
tests/dotnet-blazor/configure-auth/eval.yaml
Expand Down Expand Up @@ -71,13 +68,8 @@ tests/dotnet11/system-text-json-net11/eval.yaml
tests/dotnet-blazor/use-js-interop/eval.yaml
tests/dotnet-experimental/exp-test-maintainability/eval.yaml
tests/dotnet-maui/maui-app-lifecycle/eval.yaml
tests/dotnet-maui/maui-collectionview/eval.yaml
tests/dotnet-maui/maui-data-binding/eval.yaml
tests/dotnet-maui/maui-dependency-injection/eval.yaml
tests/dotnet-maui/maui-safe-area/eval.yaml
tests/dotnet-maui/maui-shell-navigation/eval.yaml
tests/dotnet-maui/maui-theming/eval.yaml
tests/dotnet-msbuild/msbuild-antipatterns/eval.yaml
tests/dotnet-template-engine/template-smart-defaults/eval.yaml
tests/dotnet-test/find-untested-sources/eval.yaml
tests/dotnet-test/generate-testability-wrappers/eval.yaml
Comment on lines 72 to 75

@AbhitejJohn AbhitejJohn Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads-up while we're in this file: check_eval_quality.py is already red on main because these three (maui-dependency-injection, maui-shell-navigation, maui-theming) are stale underpowered exemptions that now clear the 5-trial floor. I verified it — clean origin/main reports 4 errors, this branch reports 3, and the one that drops is maui-collectionview (which this PR removes). So this PR isn't the cause and actually improves the count.

Since we're editing the allowlist anyway, want to drop these three stale lines too and get the gate green in the same change? None of them are in the eight-skill scope, so it's purely opportunistic — fine to skip if you'd rather keep this PR tightly scoped.

(Copilot, commenting on Abhitej's behalf.)

Expand Down
148 changes: 0 additions & 148 deletions plugins/dotnet-diag/skills/android-tombstone-symbolication/SKILL.md
View file
Open in desktop

This file was deleted.

Loading
Loading