Improve dotnet-test-migration skill signal

plugins/dotnet-test-migration/skills/migrate-mstest-v1v2-to-v3/SKILL.md

@@ -8,8 +8,8 @@ description: >
   USE FOR: upgrading from MSTest v1 assembly references
   (Microsoft.VisualStudio.QualityTools.UnitTestFramework) or MSTest v2 NuGet
   (MSTest.TestFramework 1.x-2.x) to MSTest v3, fixing assertion overload
-  errors (AreEqual/AreNotEqual), updating DataRow constructors, replacing
-  .testsettings with .runsettings, timeout behavior changes, target framework
+  errors (AreEqual/AreNotEqual), updating DataRow constructors, replacing or
+  migrating .testsettings to .runsettings, timeout behavior changes, target framework
   compatibility (.NET 5 dropped -- use .NET 6+; .NET Fx older than 4.6.2 dropped),
   adopting MSTest.Sdk while moving from v1/v2.
   First step toward MSTest v4 -- after this, use migrate-mstest-v3-to-v4.
@@ -37,6 +37,13 @@ Migrate a test project from MSTest v1 (assembly references) or MSTest v2 (NuGet
 - Upgrading v3 to v4 -- use `migrate-mstest-v3-to-v4`
 - Migrating between frameworks (MSTest to xUnit/NUnit)
 
+## Boundary Gate
+
+Check package versions before any edit. If all MSTest references are already 3.x
+and no v1/v2-to-v3 error is reported, state that migration is complete and make
+no changes. Do not consolidate working v3 packages into the metapackage. Run the
+existing tests only if verification was requested. This overrides all steps below.
+
 ## Inputs
 
 | Input | Required | Description |
@@ -58,18 +65,25 @@ MSTest v3 introduces these breaking changes from v1/v2. Address only the ones re
 | Timeout behavior unified across .NET Core / Framework | Tests with `[Timeout]` may behave differently | Verify timeout values; adjust if needed |
 | Dropped target frameworks: .NET 5, .NET Fx < 4.6.2, netstandard1.0, UWP < 16299, WinUI < 18362 | Build error | Update TFM: .NET 5 -> net8.0 (LTS) or net6.0+, netfx -> net462+, netstandard1.0 -> netstandard2.0. Note: net6.0, net8.0, net9.0 are all supported |
 | Not binary compatible with v1/v2 | Libraries compiled against v1/v2 must be recompiled | Recompile all dependencies against v3 |
+| Test ID generation changed | Playlists, filters, or CI history keyed by test ID may reset | Re-baseline IDs and verify affected filters |
+| `TargetInvocationException` is unwrapped | Tests or infrastructure expecting the wrapper observe the inner exception | Update exception handling to expect the underlying exception |
+| Initialization/cleanup messages now attach to test results | The first/last test output may gain lifecycle messages that were previously absent | Update log processing and inspect the first/last test results |
+| Deployment directory behavior is unified across TFMs | Tests with hard-coded deployment paths may fail | Use `TestContext.DeploymentDirectory` or deployed-item paths instead of assumptions |
+| Nullable annotations were added | Nullable-enabled projects may gain warnings | Fix the warnings without suppressing unrelated diagnostics |
 
 ## Response Guidelines
 
 - **Always identify the current version first**: Before recommending any migration steps, explicitly state the current MSTest version detected in the project (e.g., "Your project uses MSTest v2 (2.2.10)" or "This is an MSTest v1 project using QualityTools assembly references"). This grounds the migration advice and confirms you've read the project files.
 - **Require project evidence**: Do not assume v1/v2 from the wording alone. Read project or central package files and classify the source as QualityTools/v1, NuGet 1.x, or NuGet 2.x. If the project is already on v3+, stop and route to the appropriate skill.
+- **Preserve the test platform**: Keep VSTest or MTP unchanged during the framework upgrade unless the user separately requests a runner migration.
 - **Execute full migrations**: When the user asks you to migrate or upgrade the project, edit the files, build, and run tests. Do not stop after listing breaking changes. Advice-only responses are appropriate only when the user asks what to expect.
 - **Focused fix requests** (user has specific compilation errors after upgrading): Address only the relevant breaking change from the table above. Show a concise before/after fix. Do not walk through the full migration workflow.
-- **Specific feature migration** (user asks about one aspect like .testsettings, DataRow, or assertions): Address only that specific aspect with a concrete fix. Do not walk through the entire migration workflow or unrelated breaking changes.
-- **"What to expect" questions** (user asks about breaking changes before upgrading): Present only the breaking changes that are clearly relevant to the user's visible code and configuration. For each, give a one-line fix summary. Do not include every possible breaking change -- only the ones that apply. Do not walk through the full workflow.
+- **DataRow fix requests**: Compare every supplied `DataRow` with its method signature. Mismatches can build with only `MSTEST0014` and fail during test execution. Preserve the method contract and normally fix the literal (`1L` -> `1` for `int`), then run the affected tests.
+- **Specific feature migration** (user asks about one aspect like .testsettings, DataRow, or assertions): Address only that feature, but handle every active setting or affected usage in the supplied files. For `.testsettings`, put all MSTest settings under one `<MSTest>` element, map requested deployment, per-test timeout, data collector, and other active configuration, and do not add a session-wide timeout. Do not walk through unrelated breaking changes.
+- **"What to expect" questions** (user asks about breaking changes before upgrading): First state the concrete package update needed to reach v3, then summarize every category in the Breaking Changes Summary, marking which ones directly apply to the visible project. Keep each item to one line and do not expand into release-note history.
 - **Full migration requests** (user wants complete migration): Follow the complete workflow below.
 - **Comparison questions** (user asks about v1 vs v2 differences): Explain concisely -- v1 uses assembly references and requires removing them first; v2 uses NuGet and just needs a version bump. Both converge on the same v3 packages and breaking changes.
-- **Keep findings project-specific**: Report only breaking changes found in the visible code/configuration. Do not dump the full compatibility table into every response.
+- **Keep execution project-specific**: For fixes and full migrations, change only patterns found in the visible code/configuration. Broader coverage is reserved for explicit "what should I expect?" questions.
 
 ## Migration Paths
 
@@ -82,13 +96,11 @@ Both paths converge at Step 3 -- the same v3 packages and breaking changes apply
 
 ### Step 1: Assess the project
 
-1. Identify which MSTest version is currently in use:
+1. In one discovery pass, batch-read project and central configuration files, search for affected APIs/settings, and identify which MSTest version is currently in use:
    - **Assembly reference**: Look for `Microsoft.VisualStudio.QualityTools.UnitTestFramework` in project references -> MSTest v1
    - **NuGet packages**: Check `MSTest.TestFramework` and `MSTest.TestAdapter` package versions -> v1 if 1.x, v2 if 2.x
-2. Read `Directory.Packages.props`, `Directory.Build.props`, and imported props/targets before editing; package versions may be centralized.
-3. Check whether the project uses `.testsettings` / `<LegacySettings>`, affected assertions, `DataRow`, or `[Timeout]`.
-4. Check if the target framework is dropped in v3 (see Step 4).
-5. Run the existing build and test command. Record discovered, passed, failed, and skipped counts as the parity baseline.
+2. Check whether the target framework is dropped in v3 (see Step 4).
+3. Run the existing test command. Record discovered, passed, failed, and skipped counts as the parity baseline.
 
 ### Step 2: Remove v1 assembly references (if applicable)
 
@@ -115,9 +127,9 @@ Keep `Microsoft.NET.Test.Sdk` when the project remains on VSTest, but update it
 
 **Use MSTest.Sdk only when the user requests it or the repository already standardizes on it (SDK-style projects only):**
 
-Change `<Project Sdk="Microsoft.NET.Sdk">` to `<Project Sdk="MSTest.Sdk/3.8.0">`. MSTest.Sdk automatically provides MSTest.TestFramework, MSTest.TestAdapter, MSTest.Analyzers, and Microsoft.NET.Test.Sdk.
+Change `<Project Sdk="Microsoft.NET.Sdk">` to `<Project Sdk="MSTest.Sdk/3.8.0">`. MSTest.Sdk automatically provides the MSTest framework, adapter, and analyzers.
 
-> **Important**: MSTest.Sdk defaults to Microsoft.Testing.Platform (MTP) instead of VSTest. For VSTest compatibility (e.g., `vstest.console` in CI), add `<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />`.
+> **Important**: MSTest.Sdk defaults to Microsoft.Testing.Platform (MTP). When preserving VSTest, set `<UseVSTest>true</UseVSTest>`; the SDK then supplies the required `Microsoft.NET.Test.Sdk` reference. Do not switch runners merely as a side effect of the framework upgrade.
 
 When switching to MSTest.Sdk, remove these (SDK provides them automatically):
 
@@ -126,7 +138,7 @@ When switching to MSTest.Sdk, remove these (SDK provides them automatically):
 
 ### Step 4: Update target frameworks if needed
 
-MSTest v3 supports .NET 6+, .NET Core 3.1, .NET Framework 4.6.2+, .NET Standard 2.0, UWP 16299+, and WinUI 18362+. If the project targets a dropped framework version, update to a supported one:
+MSTest v3 supports .NET 6+, .NET Core 3.1, .NET Framework 4.6.2+, .NET Standard 2.0, UWP 16299+, and WinUI 18362+. .NET Core 3.1 is end-of-life but remains supported by MSTest v3; preserve it during this framework-only migration and recommend a separate runtime upgrade. If the project targets a framework version dropped by MSTest v3, update to a supported one:
 
 | Dropped | Recommended replacement |
 |---------|------------------------|
@@ -140,7 +152,9 @@ MSTest v3 supports .NET 6+, .NET Core 3.1, .NET Framework 4.6.2+, .NET Standard
 
 ### Step 5: Resolve build errors and breaking changes
 
-Search the project for the affected APIs, then run the build and fix only the breaking changes that are present. Do not perform speculative rewrites.
+Search the supplied files first and fix only breaking changes that are present.
+A successful build does not prove compatibility; some failures surface only as
+analyzer warnings or during test execution.
 
 **Assertion overloads** -- MSTest v3 removed `Assert.AreEqual(object, object)` and `Assert.AreNotEqual(object, object)`. Add explicit generic type parameters:
 
@@ -158,11 +172,14 @@ Assert.AreSame(expected, actual);         -> Assert.AreSame<MyType>(expected, ac
 // Error: 1.0 (double) won't convert to float parameter -> fix: use 1.0f (float)
 ```
 
+Preserve method parameter types unless independently wrong. `dotnet build` may
+succeed with `MSTEST0014`; run the test to prove each row binds and executes.
+
 **Timeout behavior** -- unified across .NET Core and .NET Framework. Verify `[Timeout]` values still work.
 
 ### Step 6: Replace .testsettings with .runsettings
 
-The `.testsettings` file and `<LegacySettings>` are no longer supported in MSTest v3. **Delete the `.testsettings` file** and create a `.runsettings` file -- do not keep both.
+The `.testsettings` file and `<LegacySettings>` are no longer supported in MSTest v3. **Delete the `.testsettings` file** and create a `.runsettings` file -- do not keep both. Consolidate all MSTest configuration under one `<MSTest>` element; do not create an `<MSTestV2>` section.
 
 Key mappings:
 
@@ -177,11 +194,10 @@ Key mappings:
 
 ### Step 7: Verify
 
-1. Run `dotnet build` -- confirm zero errors and review any new warnings
-2. Run the same test command, filter, and configuration used for the baseline
-3. Compare discovered, passed, failed, and skipped counts to the pre-migration baseline
-4. Investigate every count difference; do not accept silently dropped tests or data rows
-5. Confirm no QualityTools reference, 1.x/2.x MSTest package, `.testsettings`, or `<LegacySettings>` remains
+1. Run the same test command, filter, and configuration used for the baseline. `dotnet test` builds by default; run a separate build only to isolate a compilation failure.
+2. Compare discovered, passed, failed, and skipped counts to the pre-migration baseline.
+3. Investigate every count difference; do not accept silently dropped tests or data rows.
+4. Confirm no QualityTools reference, 1.x/2.x MSTest package, `.testsettings`, or `<LegacySettings>` remains.
 
 ## Validation
 
@@ -198,5 +214,5 @@ After v3 migration, use `migrate-mstest-v3-to-v4` for MSTest v4.
 
 | Pitfall | Solution |
 |---------|----------|
-| Missing `Microsoft.NET.Test.Sdk` | Add package reference -- required for test discovery with VSTest |
-| MSTest.Sdk tests not found by `vstest.console` | MSTest.Sdk defaults to Microsoft.Testing.Platform; add explicit `Microsoft.NET.Test.Sdk` for VSTest compatibility |
+| Non-MSTest.Sdk VSTest project missing `Microsoft.NET.Test.Sdk` | Add the package reference for VSTest discovery |
+| MSTest.Sdk tests not found by `vstest.console` | Set `<UseVSTest>true</UseVSTest>`; MSTest.Sdk then supplies `Microsoft.NET.Test.Sdk` |