Skip to content

dotnet-test: raise timeout for assertion-quality decline-write-tests scenario - #862

Merged
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/fix-assertion-quality-eval-timeout
Jul 7, 2026
Merged

dotnet-test: raise timeout for assertion-quality decline-write-tests scenario#862
Evangelink merged 1 commit into
mainfrom
dev/amauryleve/fix-assertion-quality-eval-timeout

Conversation

@Evangelink

Copy link
Copy Markdown
Member

What

Raises the per-scenario timeout from 300 to 360 for the "Decline request to write new tests from scratch" scenario in tests/dotnet-test/assertion-quality/eval.yaml.

Why

This non-activation scenario asks the agent to write a full MSTest test suite from scratch — a code-generation task — and its rubric requires the agent to actually produce the tests. It was hitting its 300s wall-clock timeout, producing empty output and failing all assertions.

Per eng/skill-validator/src/docs/InvestigatingResults.md, timeouts are the highest-priority failure mode and code-generation scenarios often need 360s. This follows the same fix pattern as #850, which raised timeouts for chronic-timeout eval scenarios (including the identically-named test-gap-analysis scenario).

…scenario 300->360

The 'Decline request to write new tests from scratch' non-activation
scenario writes a full MSTest suite from scratch (code generation) and
was hitting its 300s wall-clock timeout. Per InvestigatingResults.md,
code-generation scenarios often need 360s.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 7, 2026 07:10
@Evangelink

Copy link
Copy Markdown
Member Author

/evaluate

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Raises the per-scenario wall-clock timeout for a single dotnet-test evaluation scenario that was frequently timing out and producing empty output, preventing the scenario’s rubric/assertions from being meaningfully evaluated.

Changes:

  • Increased the timeout for the “Decline request to write new tests from scratch” scenario in tests/dotnet-test/assertion-quality/eval.yaml from 300 to 360.
Show a summary per file
File Description
tests/dotnet-test/assertion-quality/eval.yaml Increases scenario timeout to reduce timeout-induced empty outputs and assertion failures.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@Evangelink
Evangelink enabled auto-merge (squash) July 7, 2026 07:11
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Skill Validation Results

Skill Scenario Quality Skills Loaded Overfit Verdict
assertion-quality Identify low assertion diversity in equality-dominated test suite 3.0/5 → 5.0/5 🟢 ✅ assertion-quality; tools: skill, glob / ✅ assertion-quality; tools: skill 🟡 0.22
assertion-quality Flag assertion-free tests and trivial-only assertions 4.3/5 → 4.0/5 🔴 ✅ assertion-quality; tools: skill, glob / ✅ assertion-quality; tools: skill 🟡 0.22 [1]
assertion-quality Recognize well-diversified assertion usage 4.0/5 → 4.7/5 🟢 ✅ assertion-quality; tools: skill, glob 🟡 0.22
assertion-quality Identify self-referential assertions in identity and round-trip tests 3.3/5 → 5.0/5 🟢 ✅ assertion-quality; tools: skill, glob / ✅ assertion-quality; tools: skill 🟡 0.22 [2]
assertion-quality Decline request to write new tests from scratch 4.0/5 → 4.0/5 ℹ️ not activated (expected) 🟡 0.22 [3]
assertion-quality Polyglot: evaluate shallow assertions in a Jest/TypeScript OrderService suite 4.3/5 → 5.0/5 🟢 ✅ assertion-quality; tools: skill, glob 🟡 0.22 [4]

[1] (Plugin) Quality unchanged but weighted score is -10.0% due to: tokens (26440 → 75330), tool calls (2 → 4), time (25.2s → 57.6s)
[2] ⚠️ High run-to-run variance (CV=54%) — consider re-running with --runs 5
[3] ⚠️ High run-to-run variance (CV=210%) — consider re-running with --runs 5. (Plugin) Quality improved but weighted score is -0.9% due to: tokens (201008 → 535924), tool calls (10 → 22), time (106.0s → 184.4s)
[4] ⚠️ High run-to-run variance (CV=275%) — consider re-running with --runs 5

Model: claude-opus-4.6 | Judge: claude-opus-4.6

🔍 Full Results - additional metrics and failure investigation steps

To investigate failures, paste this to your AI coding agent:

For PR 862 in dotnet/skills, download eval artifacts with gh run download 28848335146 --repo dotnet/skills --pattern "skill-validator-results-*" --dir ./eval-results, then fetch https://raw.githubusercontent.com/dotnet/skills/b7c8f56df109572e2c0b3614e137c503a9c4c118/eng/skill-validator/src/docs/InvestigatingResults.md and follow it to analyze the results.json files. Diagnose each failure, suggest fixes to the eval.yaml and skill content, and tell me what to fix first.

▶ Sessions Visualisation -- interactive replay of all evaluation sessions
📊 Session Analytics (preview) -- aggregated metrics across evaluation sessions

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

✅ Evaluation passed for b7c8f56. cc @dotnet/dotnet-testing — please review.

@Evangelink
Evangelink merged commit 0451fe8 into main Jul 7, 2026
35 of 37 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/fix-assertion-quality-eval-timeout branch July 7, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-review PR state label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants