Skip to content

Fix hashtable .Keys/.Values collision in skill coverage tool #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
Jun 25, 2026
Merged

Fix hashtable .Keys/.Values collision in skill coverage tool #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions eng/skill-coverage/Measure-SkillCoverage.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function Get-CodePatterns([string]$content) {
if ($inCode) { $block += "$line`n" }
}

$seen.Values | ForEach-Object {
$seen.get_Values() | ForEach-Object {
[PSCustomObject]@{
Category = 'CodePattern'
Description = $_[0]
Expand Down Expand Up @@ -257,7 +257,7 @@ function Get-BlockPatterns([string]$code) {
if ($code -match $_.Value) { $found[$_.Key.ToLower()] = $_.Key }
}

$found.Values
$found.get_Values()
}

function Get-SignificantTerms([string]$text) {
Expand All @@ -283,7 +283,10 @@ function Get-SignificantTerms([string]$text) {
}
}

[string[]]$terms.Keys
# Use get_Keys() rather than .Keys: if a significant term is literally
# "keys", PowerShell's hashtable member access returns that entry's value
# instead of the key collection, collapsing the keyword set.
[string[]]$terms.get_Keys()
}

# ═══════════════════════════════════════════════════════════
Expand Down