Align writing-mstest-tests skill routing with anti-pattern disambiguation

[Copilot]

This updates writing-mstest-tests to match the review-thread requirement: anti-pattern/test-quality audits should route to test-anti-patterns, while this skill stays focused on writing and modernizing MSTest tests.

• Routing and scope alignment

  • Removed anti-pattern review positioning from When to Use
  • Added explicit redirect in When Not to Use for anti-pattern/test-quality audits → test-anti-patterns

• Input wording cleanup

  • Updated the “Existing test code” input description to emphasize improve/modernize instead of review

• Result

  • Frontmatter/body guidance is now consistent and avoids conflicting activation signals between the two skills.

## When Not to Use

- User needs to review or audit existing tests for anti-patterns or test quality (use `test-anti-patterns`)

[github-actions]

Skill Coverage Report

	Plugin	Skill	Covered	Coverage
⚠️	dotnet-test	writing-mstest-tests	42/62	67.7%

Uncovered: dotnet-test/writing-mstest-tests

• [Validation] Project builds with zero errors and all tests pass (line 333)
• [WorkflowStep] Step 7: Use advanced features where appropriate (line 290)
• [CodePattern] [Retry] (line 296)
• [CodePattern] [DoNotParallelize] (line 316)
• [CodePattern] Assert.DoesNotContain (line 137)
• [CodePattern] [CICondition] (line 304)
• [CodePattern] [OSCondition] (line 304)
• [CodePattern] Assert.AreSame (line 113)
• [CodePattern] Assert.EndsWith (line 158)
• [CodePattern] MSTest.Sdk (line 46)
• [CodePattern] Assert.IsEmpty (line 137)
• [CodePattern] DoNotParallelize (line 316)
• [CodePattern] Assert.IsInRange (line 178)
• [CodePattern] Assert.IsLessThan (line 178)
• [CodePattern] [TestCleanup] (line 239)
• [CodePattern] Parallelize (line 316)
• [CodePattern] Assert.StartsWith (line 158)
• [CodePattern] Assert.IsGreaterThan (line 178)
• [CodePattern] Assert.IsNull (line 113)
• [CodePattern] Assert.MatchesRegex (line 158)

[Evangelink]

/evaluate

[Copilot]

Pull request overview

This PR refines the writing-mstest-tests skill’s scope so it focuses on writing/fixing/modernizing MSTest tests, while explicitly routing anti-pattern and test-quality audits to test-anti-patterns.

Changes:

• Removes anti-pattern review positioning from When to Use and reframes it as “targeted help fixing/modernizing”.
• Adds explicit When Not to Use redirect for anti-pattern/test-quality audits → test-anti-patterns.
• Updates the “Existing test code” input wording from “review” to “improve/modernize”.

Show a summary per file

File	Description
plugins/dotnet-test/skills/writing-mstest-tests/SKILL.md	Adjusts skill routing/scope text to avoid conflicting activation with test-anti-patterns.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 1

[github-actions]

Skill Validation Results

Skill	Scenario	Quality	Skills Loaded	Overfit	Verdict
writing-mstest-tests	Write unit tests for a service class	4.3/5 → 4.0/5 🔴	✅ writing-mstest-tests; tools: skill / ✅ code-testing-agent; writing-mstest-tests; tools: skill, task	🟡 0.21	❌
writing-mstest-tests	Write data-driven tests for a calculator	4.7/5 → 4.7/5	✅ writing-mstest-tests; tools: skill, glob / ✅ writing-mstest-tests; tools: skill, bash, edit	🟡 0.21	❌ [1]
writing-mstest-tests	Write async tests with cancellation	2.7/5 → 5.0/5 🟢	✅ writing-mstest-tests; tools: skill	🟡 0.21	✅
writing-mstest-tests	Fix swapped Assert.AreEqual arguments	5.0/5 → 5.0/5	✅ writing-mstest-tests; tools: report_intent, skill / ⚠️ NOT ACTIVATED	🟡 0.21	✅ [2]
writing-mstest-tests	Modernize legacy test patterns	4.0/5 ⏰ → 4.7/5 🟢	✅ writing-mstest-tests; tools: skill	🟡 0.21	❌ [3]
writing-mstest-tests	Replace ExpectedException with Assert.Throws	3.0/5 → 4.3/5 🟢	✅ writing-mstest-tests; tools: skill / ✅ writing-mstest-tests; tools: skill, report_intent	🟡 0.21	✅
writing-mstest-tests	Use proper collection assertions	3.0/5 → 2.3/5 🔴	✅ writing-mstest-tests; tools: skill	🟡 0.21	❌ [4]
writing-mstest-tests	Use proper type assertions instead of casts	3.0/5 → 3.7/5 🟢	✅ writing-mstest-tests; tools: report_intent, skill / ⚠️ NOT ACTIVATED	🟡 0.21	✅ [5]
writing-mstest-tests	Set up test lifecycle correctly	1.7/5 → 4.0/5 🟢	✅ writing-mstest-tests; tools: skill	🟡 0.21	✅
writing-mstest-tests	Use DynamicData with ValueTuples over object arrays	2.7/5 → 4.3/5 🟢	✅ writing-mstest-tests; tools: report_intent, skill / ⚠️ NOT ACTIVATED	🟡 0.21	✅ [6]

[1] ⚠️ High run-to-run variance (CV=3.19) — consider re-running with --runs 5. (Plugin) Quality improved but weighted score is -1.0% due to: tokens (144199 → 435664), tool calls (14 → 23), time (88.3s → 141.3s)
[2] ⚠️ High run-to-run variance (CV=3.76) — consider re-running with --runs 5
[3] ⚠️ High run-to-run variance (CV=2.12) — consider re-running with --runs 5
[4] ⚠️ High run-to-run variance (CV=16.52) — consider re-running with --runs 5
[5] ⚠️ High run-to-run variance (CV=1.67) — consider re-running with --runs 5
[6] ⚠️ High run-to-run variance (CV=1.62) — consider re-running with --runs 5

⏰ timeout — run(s) hit the (180s) scenario timeout limit; scoring may be impacted by aborting model execution before it could produce its full output (increase via timeout in eval.yaml)

Model: claude-opus-4.6 | Judge: claude-opus-4.6

🔍 Full Results - additional metrics and failure investigation steps

▶ Sessions Visualisation -- interactive replay of all evaluation sessions