Add fsharp-project-structure skill by T-Gro · Pull Request #248 · dotnet/skills

T-Gro · 2026-03-05T21:58:10Z

Adds skill for F# project file structure: compilation order, .fsi signature files, and common FS0039/FS0010/FS0034 fixes.

Eval results (gpt-4.1, 3 runs, judged by claude-opus-4.6):

Scenario	Baseline	With Skill	Pairwise
Add module to project	2.3/5	5.0/5	MuchBetter
Fix broken file order (FS0039)	2.7/5	4.3/5	MuchBetter
Add .fsi signature file	1.7/5	4.0/5	MuchBetter

Overall: +64.6%, significant, CI [+17.2%, +63.0%], overfitting 0.08 (low).

… files Teaches agents F# compilation order rules, signature file placement, and common FS0039/FS0010/FS0034 fixes. Includes eval with three scenarios (add module, fix broken order, add signature file) and test fixtures. Validated +64.6% improvement on gpt-4.1 (significant, CI [+17.2%, +63.0%]). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ro/skills into feature/fsharp-projects-mgmt

Copilot

Pull request overview

Adds a new .NET skill focused on F# .fsproj compilation ordering and signature file (.fsi) placement, along with an eval suite and fixtures to measure improvements.

Changes:

Added fsharp-project-structure skill documentation under plugins/dotnet/skills/.
Added eval scenarios + F# project fixtures under tests/dotnet/fsharp-project-structure/.
Updated .github/CODEOWNERS to assign ownership for the new skill and test area.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/dotnet/fsharp-project-structure/eval.yaml	Adds 3 eval scenarios covering adding modules, fixing file order, and adding `.fsi` signature files.
tests/dotnet/fsharp-project-structure/OrderService/Domain.fs	Adds an F# domain model fixture for ordering/signature scenarios.
tests/dotnet/fsharp-project-structure/OrderService/Services.fs	Adds an F# services fixture referencing `Domain`.
tests/dotnet/fsharp-project-structure/OrderService/Program.fs	Adds an executable entry point fixture used by scenarios.
tests/dotnet/fsharp-project-structure/OrderService/OrderService.fsproj	Adds a “correctly ordered” `.fsproj` fixture.
tests/dotnet/fsharp-project-structure/BrokenOrder/Domain.fs	Adds a domain fixture used in the “broken order” scenario.
tests/dotnet/fsharp-project-structure/BrokenOrder/Services.fs	Adds a services fixture that will fail if compiled before `Domain.fs`.
tests/dotnet/fsharp-project-structure/BrokenOrder/Program.fs	Adds an entry point fixture for the broken-order project.
tests/dotnet/fsharp-project-structure/BrokenOrder/BrokenOrder.fsproj	Adds an intentionally misordered `.fsproj` fixture to trigger FS0039.
plugins/dotnet/skills/fsharp-project-structure/SKILL.md	Adds the new skill guidance for `.fsproj` ordering and `.fsi` rules.
.github/CODEOWNERS	Assigns code owners for the new skill and its tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ViktorHofer · 2026-03-06T14:53:39Z

/evaluate

github-actions · 2026-03-06T15:02:10Z

Skill Validation Results

Skill	Scenario	Baseline	With Skill	Δ	Skills Loaded	Overfit	Verdict
dotnet-trace-collect	High CPU in Kubernetes on Linux (.NET 8)	4.0/5	5.0/5	+1.0	✅ dotnet-trace-collect; tools: skill, report_intent, view	✅ 0.18	✅
dotnet-trace-collect	.NET Framework on Windows without admin privileges	2.3/5	5.0/5	+2.7	✅ dotnet-trace-collect; tools: skill	✅ 0.18	✅
dotnet-trace-collect	.NET 10 on Linux with root access and native call stacks	1.0/5	4.3/5	+3.3	✅ dotnet-trace-collect; tools: skill	✅ 0.18	✅
dotnet-trace-collect	Memory leak on Linux (.NET 8)	3.0/5	3.3/5	+0.3	✅ dotnet-trace-collect; tools: skill, report_intent, view	✅ 0.18	✅
dotnet-trace-collect	Slow requests on Windows with PerfView	4.7/5	5.0/5	+0.3	✅ dotnet-trace-collect; tools: skill, report_intent, view, glob	✅ 0.18	❌
dotnet-trace-collect	Excessive GC on Linux (.NET 8)	4.0/5	4.7/5	+0.7	✅ dotnet-trace-collect; tools: skill	✅ 0.18	❌
dotnet-trace-collect	Hang or deadlock diagnosis on Linux	3.7/5	4.0/5	+0.3	✅ dotnet-trace-collect; tools: skill, report_intent, view	✅ 0.18	✅
dotnet-trace-collect	Windows container high CPU with PerfView	1.7/5	5.0/5	+3.3	✅ dotnet-trace-collect; tools: skill, report_intent, view, glob	✅ 0.18	✅
dotnet-trace-collect	Long-running intermittent issue with PerfView triggers	3.0/5	5.0/5	+2.0	✅ dotnet-trace-collect; tools: skill, report_intent, view, glob	✅ 0.18	✅
dotnet-trace-collect	Linux pre-.NET 10 needing native call stacks	2.0/5	5.0/5	+3.0	✅ dotnet-trace-collect; tools: skill, report_intent, view, glob	✅ 0.18	✅
dotnet-trace-collect	Windows modern .NET with admin high CPU	2.3/5	5.0/5	+2.7	✅ dotnet-trace-collect; tools: skill, report_intent, view, glob	✅ 0.18	✅
dotnet-trace-collect	Memory leak on .NET Framework Windows	3.3/5	5.0/5	+1.7	✅ dotnet-trace-collect; tools: skill, report_intent, view	✅ 0.18	✅
dotnet-trace-collect	Kubernetes with console access prefers console tools	5.0/5	4.7/5	-0.3	✅ dotnet-trace-collect; tools: skill, report_intent, view, glob	✅ 0.18	✅
dotnet-trace-collect	Container installation without .NET SDK	3.3/5	4.0/5	+0.7	✅ dotnet-trace-collect; tools: skill	✅ 0.18	✅
dotnet-pinvoke	Generate LibraryImport declaration from C header (.NET 8+)	3.7/5	5.0/5	+1.3	✅ dotnet-pinvoke; tools: skill	✅ 0.11	✅
dotnet-pinvoke	Generate LibraryImport declaration from C header (.NET Framework)	3.7/5	5.0/5	+1.3	✅ dotnet-pinvoke; tools: skill	✅ 0.11	✅
fsharp-project-structure	Add a module to an F# project	5.0/5	5.0/5	0.0	✅ fsharp-project-structure; tools: skill	✅ 0.08	✅
fsharp-project-structure	Fix broken file order causing FS0039	4.3/5	4.0/5	-0.3	⚠️ NOT ACTIVATED	✅ 0.08	❌
fsharp-project-structure	Add a signature file to define public API	5.0/5	5.0/5	0.0	✅ fsharp-project-structure; tools: skill, glob, read_bash	✅ 0.08	❌

Model: claude-opus-4.6 | Judge: claude-opus-4.6

Full results

ManishJayaswal · 2026-03-10T04:35:15Z

@T-Gro - can you update this PR to create a new plugin named dotnet-fsharp and add this skill to it?

…ts-mgmt

Scraps the standalone fsharp-project-structure skill and instead adds a short F# exception to AP-05 (Manual File Listing in SDK-Style Projects): F# compilation is order-dependent, so .fsproj files must list Compile items in dependency order (utilities first, entry point last), and .fsi signature files must appear immediately before their companion .fs. The three F# eval scenarios (add module, fix broken order, add signature file) are ported into tests/dotnet-msbuild/msbuild-antipatterns/eval.yaml with fixtures isolated under a fsharp/ subfolder (with empty Directory.Build.{props,targets} to prevent the existing C#-antipattern fixture files from leaking into the F# builds). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

T-Gro · 2026-04-22T18:36:29Z

Superseded by a smaller change folding the guidance into msbuild-antipatterns AP-05 instead of shipping a standalone skill. New PR incoming.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-22T18:39:51Z

+      - type: "exit_success"
+      - type: "file_contains"
+        path: "fsharp/BrokenOrder/BrokenOrder.fsproj"
+        value: "Domain.fs"


The assertions for this scenario don’t actually verify that the .fsproj file ordering was fixed: Domain.fs is already present in the broken fixture, so file_contains: Domain.fs will pass even if no reordering happens (or if the build is made to pass by editing .fs source files instead). Strengthen assertions to check that Domain.fs appears before Services.fs (and ideally that the inverse ordering is not present), and/or assert that no .fs files were modified.

Suggested change

value: "Domain.fs"

value: |

Domain.fs" />

<Compile Include="Services.fs"

Copilot · 2026-04-22T18:39:52Z

 ## Directory.Build Consolidation

-Identify properties repeated across multiple `.csproj` files and move them to shared files.
-
-**`Directory.Build.props`** (for properties — placed at repo or src root):
-
-```xml
-<Project>
-  <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
-    <Nullable>enable</Nullable>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-    <Company>Contoso</Company>
-    <Copyright>Copyright © Contoso 2024</Copyright>
-  </PropertyGroup>
-</Project>
-```
-
-**`Directory.Build.targets`** (for targets/t
+Identify properties repeated across multiple `

 [truncated]


This auto-generated lock file appears to be accidentally truncated: the "Directory.Build Consolidation" section ends mid-sentence and the literal placeholder text [truncated] is committed. Regenerate this compiled lock (or restore the removed content) so the document is complete and does not contain placeholders.

T-Gro and others added 3 commits March 5, 2026 22:53

Merge branch 'feature/fsharp-projects-mgmt' of https://github.com/T-G…

ddfcf42

…ro/skills into feature/fsharp-projects-mgmt

T-Gro requested a review from timheuer as a code owner March 5, 2026 21:58

Copilot AI review requested due to automatic review settings March 5, 2026 21:58

T-Gro requested a review from dbreshears as a code owner March 5, 2026 21:58

Copilot started reviewing on behalf of T-Gro March 5, 2026 21:58 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Update plugins/dotnet/skills/fsharp-project-structure/SKILL.md

da175b1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

T-Gro requested a review from a team March 6, 2026 10:35

danmoseley added the skill label Mar 9, 2026

github-actions Bot mentioned this pull request Mar 19, 2026

🏥 Repository Health Dashboard #288

Closed

This was referenced Apr 13, 2026

Log exceptions in AgentRunner.StopAllClients catch block #349

Closed

Add --run-in-docker to skill-validator to run Copilot CLI in a docker container #273

Closed

T-Gro and others added 2 commits April 21, 2026 13:53

Merge remote-tracking branch 'origin/main' into feature/fsharp-projec…

51b2ce3

…ts-mgmt

Copilot AI review requested due to automatic review settings April 22, 2026 18:36

T-Gro requested review from JanKrivanek and ViktorHofer as code owners April 22, 2026 18:36

T-Gro requested a review from a team April 22, 2026 18:36

T-Gro closed this Apr 22, 2026

T-Gro mentioned this pull request Apr 22, 2026

Fold F# .fsproj ordering into msbuild-antipatterns AP-05 #577

Merged

Copilot started reviewing on behalf of T-Gro April 22, 2026 18:36 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Navigation Menu

Uh oh!

Add fsharp-project-structure skill - #248

Add fsharp-project-structure skill#248
T-Gro wants to merge 6 commits into
dotnet:mainfrom
T-Gro:feature/fsharp-projects-mgmt

T-Gro commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Uh oh!

ManishJayaswal commented Mar 10, 2026

Uh oh!

T-Gro commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

-        value: "Domain.fs"
+        value: |
+          Domain.fs" />
+              <Compile Include="Services.fs"

Uh oh!

Conversation

T-Gro commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ViktorHofer commented Mar 6, 2026

Uh oh!

github-actions Bot commented Mar 6, 2026

Skill Validation Results

Uh oh!

ManishJayaswal commented Mar 10, 2026

Uh oh!

T-Gro commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants