Skip to content

[dotnet-ai] Plugin scaffold + MEAI chat integration #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luisquintanilla wants to merge 4 commits into from
Closed

[dotnet-ai] Plugin scaffold + MEAI chat integration #237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
821cce5
Add dotnet-ai plugin scaffold
luisquintanilla Mar 5, 2026
6e13c50
Address review: add missing dirs, fix key ordering
luisquintanilla Mar 5, 2026
8557701
Add meai-chat-integration skill to scaffold
luisquintanilla Mar 6, 2026
2cdadc7
Update .NET 8 references to .NET 10 (current LTS)
luisquintanilla Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,6 @@
/tests/dotnet/dotnet-aot-compat/ @agocke @dotnet/appmodel

/plugins/dotnet/agents/optimizing-dotnet-performance.agent.md @dotnet/appmodel

/plugins/dotnet-ai/ @luisquintanilla @JeremyLikness
/tests/dotnet-ai/ @luisquintanilla @JeremyLikness

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These CODEOWNERS entries add ownership for /tests/dotnet-ai/, but the tests/dotnet-ai/ directory does not exist in the repo after this change. Since evaluation workflows key off the presence of tests/<plugin>/, the scaffold PR should create tests/dotnet-ai/ (e.g., with a .gitkeep) so later skill PRs will be evaluated as expected.

Suggested change
/plugins/dotnet-ai/ @luisquintanilla @JeremyLikness
/tests/dotnet-ai/ @luisquintanilla @JeremyLikness
/plugins/dotnet-ai/ @luisquintanilla @JeremyLikness

Copilot uses AI. Check for mistakes.

@luisquintanilla luisquintanilla Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concern accepted, code suggestion rejected.

The concern is valid tests/dotnet-ai/ should exist in the scaffold PR. Added tests/dotnet-ai/.gitkeep in 6e13c50.

However, the code suggestion to remove the /tests/dotnet-ai/ CODEOWNERS entry is wrong we need ownership coverage for the test directory so that when eval files land in subsequent PRs, they require review from the plugin owners. Removing the entry would leave test files unprotected.

7 changes: 6 additions & 1 deletion .github/plugin/marketplace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@
"name": "dotnet-msbuild",
"source": "./plugins/dotnet-msbuild",
"description": "Comprehensive MSBuild and .NET build skills: failure diagnosis, performance optimization, code quality, and modernization."
},
{
"source": "./plugins/dotnet-ai",
"name": "dotnet-ai",

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file, the existing plugin entries use the key order name, source, description, but the new dotnet-ai entry uses source before name. JSON object key order is semantically irrelevant, but keeping a consistent ordering across entries makes diffs and manual maintenance easier; consider matching the existing order here.

Suggested change
"source": "./plugins/dotnet-ai",
"name": "dotnet-ai",
"name": "dotnet-ai",
"source": "./plugins/dotnet-ai",

Copilot uses AI. Check for mistakes.

@luisquintanilla luisquintanilla Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted. Good catch fixed the key ordering to match existing entries (name, source, description) in 6e13c50.

"description": "AI and ML skills for .NET: technology selection, LLM integration, ML.NET, vector search, RAG, ONNX inference, and agentic workflows."
}
]
}
}
Empty file added plugins/dotnet-ai/agents/.gitkeep
View file
Open in desktop
Empty file.
7 changes: 7 additions & 0 deletions plugins/dotnet-ai/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "dotnet-ai",
"version": "0.1.0",
"description": "AI and ML skills for .NET: technology selection, LLM integration, ML.NET, vector search, RAG, ONNX inference, and agentic workflows.",
"skills": "./skills/",

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin.json declares a "skills": "./skills/" directory, but plugins/dotnet-ai/skills/ is not present in this PR. This makes the plugin scaffold incomplete and forces later PRs to introduce the directory structure that this PR is supposed to establish. Add plugins/dotnet-ai/skills/ (e.g., with a .gitkeep) in this PR so the manifest references an existing path.

Suggested change
"skills": "./skills/",
"skills": "./",

Copilot uses AI. Check for mistakes.

@luisquintanilla luisquintanilla Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concern accepted, code suggestion rejected.

The concern is valid the skills/ directory should exist in the scaffold PR. Added plugins/dotnet-ai/skills/.gitkeep in 6e13c50.

However, the code suggestion to change "skills": "./skills/" to "skills": "./" is incorrect. Both existing plugins (dotnet and dotnet-msbuild) use "skills": "./skills/" changing to "./" would break the convention and make the plugin look for skills in the root directory instead of the skills/ subdirectory.

"agents": "./agents/"
}