Repository navigation
[release/11.0.1xx] Honor MTP zero-tests and exit-code policies in dotnet test - #56303
Merged
Evangelink merged 3 commits intoSep 15, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Reconstruct zero-test and ignored-exit policies from explicit and default test configuration files, and match process environment casing and override order on Windows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Seven moderate findings remain unresolved across policy reconstruction, cancellation reporting, and Unix-specific regression coverage.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open (1)
What changed in this PR
Backports MTP zero-test and ignored-exit-code policy handling to dotnet test for the release/11.0.1xx branch.
Changes:
- Reconstructs policies from CLI arguments, response/configuration files, and environment variables.
- Applies policies to aggregate exit codes and terminal summaries.
- Adds parser, queue, reporter, and end-to-end regression tests.
| File | Review notes |
|---|---|
test/dotnet.Tests/CommandTests/Test/TestCommandParserTests.cs |
No final findings. |
test/dotnet.Tests/CommandTests/Test/TestApplicationActionQueueTests.cs |
No final findings. |
test/dotnet.Tests/CommandTests/Test/TerminalTestReporterTests.cs |
No final findings. |
test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTests.cs |
Moderate (1 vote): add Unix case-sensitive coverage for the lowercase launch-profile environment variable. |
src/Cli/dotnet/Commands/Test/MTP/TestApplicationActionQueue.cs |
No final findings. |
src/Cli/dotnet/Commands/Test/MTP/Terminal/TerminalTestReporter.cs |
Moderate (1 vote): preserve cancellation in the failure decision so cancelled runs are reported as aborted. |
src/Cli/dotnet/Commands/Test/MTP/Options.cs |
No final findings. |
src/Cli/dotnet/Commands/Test/MTP/MicrosoftTestingPlatformTestCommand.cs |
Moderate findings: validate repeated policy options consistently (1 vote); guard config-path normalization (1 vote); guard response-file path normalization (1 vote); add Unix case-sensitive coverage (2 votes); distinguish a missing config value from an absent option (1 vote). |
Evangelink
enabled auto-merge (squash)
September 15, 2026 11:58
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
YuliiaKovalova
approved these changes
Sep 15, 2026
Evangelink
had a problem deploying
to
copilot-pat-pool
September 15, 2026 14:29 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Backport the MTP zero-tests and exit-code policy fixes from 6eb73fc and the validated follow-up e08c3f4 to
release/11.0.1xx..testconfig.jsonfilesThe cherry-pick conflicts were limited to
MicrosoftTestingPlatformTestCommand.csandTestCommandParserTests.cs; the resolutions preserve release-only retry and output behavior without importing unrelated main-only changes.References #56219 and #56296.
Validation
build.cmddotnet.Tests: 67 passed, 0 failed, 1 platform-specific skip (68 total)