Skip to content

Use versioned SDK directory for AOT forwarding apps - #55923

Merged
baronfel merged 1 commit into
mainfrom
copilot/baronfel/fix-aot-forwarding-paths
Aug 26, 2026
Merged

Use versioned SDK directory for AOT forwarding apps#55923
baronfel merged 1 commit into
mainfrom
copilot/baronfel/fix-aot-forwarding-paths

Conversation

@baronfel

Copy link
Copy Markdown
Member

Summary

  • resolve NuGet, VSTest, and FSI forwarding assets from the versioned SDK directory
  • preserve the VSTest path override and FSI DLL/EXE fallback behavior
  • add NativeAOT regression tests for all three SDK-relative paths

Testing

  • SdkForwardingAppTests: 3 passed (managed and NativeAOT-published)
  • GivenDotnetVsTestForwardingApp: 2 passed
  • NativeAOT redist checks: dotnet nuget --help, dotnet vstest --help, and dotnet fsi --help passed in a separated muxer/SDK layout

Stacked on #55920.

@baronfel
baronfel requested review from a team as code owners August 25, 2026 18:19
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
3 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@baronfel baronfel added the Area-dotnet AOT Items that are part of the dotnet CLI AOT-ification effort label Aug 25, 2026
Base automatically changed from copilot/fix-dotnet-format-forwarding to main August 25, 2026 21:52
@baronfel
baronfel requested a review from a team as a code owner August 25, 2026 21:52
Resolve NuGet, VSTest, and FSI assets from SdkPaths so NativeAOT help forwarding uses the selected SDK instead of the muxer directory.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c6929a73-7e24-4f78-830c-f6ae2a14b812
@baronfel
baronfel force-pushed the copilot/baronfel/fix-aot-forwarding-paths branch from d8dac0e to 837219c Compare August 25, 2026 21:52

@Evangelink Evangelink left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One regression-coverage issue found.

Note

This review content was generated with AI assistance.

Comment thread test/dotnet-aot.Tests/SdkForwardingAppTests.cs
@baronfel

Copy link
Copy Markdown
Member Author

@dsplaisted this needs a re-review because the 'base' commit moved, when you have a moment.

@baronfel
baronfel merged commit 9ba0e48 into main Aug 26, 2026
27 checks passed
@baronfel
baronfel deleted the copilot/baronfel/fix-aot-forwarding-paths branch August 26, 2026 15:34
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-dotnet AOT Items that are part of the dotnet CLI AOT-ification effort

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants