Fix race in Razor dispatcher test - #55515
Merged
davidwengier merged 1 commit intoJul 29, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2e8856e4-2e41-47cb-90c0-2afb0c5be773
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an intermittent hang in the Razor tool test Dispatcher_ProcessSimultaneousConnections_HitsKeepAliveTimeout (#55494) by removing race-prone synchronization in the test and ensuring the test fails fast instead of hanging indefinitely.
Changes:
- Add a bounded timeout to key awaits (
readySource,allCompilationsComplete, and the dispatcher task) to prevent indefinite hangs. - Use
TaskCreationOptions.RunContinuationsAsynchronouslyfor the test’sTaskCompletionSourceinstances to avoid inline continuations causing deadlocks/starvation. - Make the compilation completion counter thread-safe via
Interlocked.Increment.
chsienki
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55494
At least I hope it does :)
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com