Skip to content

Default BuildProjectReferences to false when NoBuild is true #55259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baronfel merged 1 commit into from
Jul 14, 2026
Merged

Default BuildProjectReferences to false when NoBuild is true #55259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Copyright (c) .NET Foundation. All rights reserved.

<!-- User-facing configuration-agnostic defaults -->
<PropertyGroup>
<BuildProjectReferences Condition="'$(BuildProjectReferences)' == '' and '$(NoBuild)' == 'true'">false</BuildProjectReferences>
<OutputType Condition=" '$(OutputType)' == '' ">Library</OutputType>
<FileAlignment Condition=" '$(FileAlignment)' == '' ">512</FileAlignment>
<ErrorReport Condition=" '$(ErrorReport)' == '' ">prompt</ErrorReport>
Expand Down
34 changes: 34 additions & 0 deletions test/Microsoft.NET.Build.Tests/GivenThatWeWantToReferenceAProject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,40 @@ public void It_copies_content_transitively()
File.Exists(contentPath).Should().BeTrue();
}

[TestMethod]
public void It_does_not_build_project_references_when_no_build_is_requested()
{
var referencedProject = new TestProject()
{
Name = "ReferencedProject",
TargetFrameworks = ToolsetInfo.CurrentTargetFramework,
};
var referencingProject = new TestProject()
{
Name = "ReferencingProject",
TargetFrameworks = ToolsetInfo.CurrentTargetFramework,
};
referencingProject.ReferencedProjects.Add(referencedProject);

var testAsset = TestAssetsManager.CreateTestProject(referencingProject);
var buildCommand = new BuildCommand(testAsset);
buildCommand.Execute().Should().Pass();

var resolveReferencesCommand = new MSBuildCommand(Log, "ResolveReferences", buildCommand.FullPathProjectFile);

resolveReferencesCommand
.Execute("/p:NoBuild=true")
.Should()
.Pass();

resolveReferencesCommand
.Execute("/p:NoBuild=true", "/p:BuildProjectReferences=true")
.Should()
.Fail()
.And
.HaveStdOutContaining("NETSDK1085");
}

[TestMethod]
public void It_conditionally_references_project_based_on_tfm()
{
Expand Down
Loading