Move VirtualProjectBuilder to FileBasedPrograms source package - #54773
Merged
Conversation
333fred
approved these changes
Jul 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 61 out of 61 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Cli/Microsoft.DotNet.FileBasedPrograms/FileLevelDirectiveHelpers.cs:15
- The source package should compile without depending on
Microsoft.DotNet.ProjectTools. This file still imports that namespace (a few lines below), but nothing inFileLevelDirectiveHelpers.csuses it, so it can break compilation for external consumers that don't referenceMicrosoft.DotNet.ProjectTools.
using System.IO;
using System.Linq;
using System.Text;
using System.Text.RegularExpressions;
using System.Xml;
using Microsoft.CodeAnalysis;
RikkiGibson
approved these changes
Jul 29, 2026
RikkiGibson
left a comment
RikkiGibson
left a comment
Member
There was a problem hiding this comment.
LGTM aside from clarifying question.
| Namespace="Microsoft.DotNet.FileBasedPrograms" /> | ||
| </ItemGroup> | ||
| <PropertyGroup> | ||
| <DefineConstants>$(DefineConstants);FILE_BASED_PROGRAMS_SOURCE_PACKAGE_GRACEFUL_EXCEPTION</DefineConstants> |
Member
There was a problem hiding this comment.
Why don't we need this any more?
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows MSBuildWorkspace in Roslyn to use VirtualProjectBuilder to construct virtual projects for file-based apps: dotnet/roslyn#84139.