Skip to content

Fix stale Known Build Error workflow (CRLF regex bug) #54174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcpopMSFT merged 2 commits into from
May 5, 2026
Merged

Fix stale Known Build Error workflow (CRLF regex bug) #54174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b84bcf
Debug stale KBE workflow: fix CRLF regex and add logging
MichaelSimons May 4, 2026
b65db1f
Fix stale KBE workflow: CRLF regex, logging, manual trigger
MichaelSimons May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: 'Stale: Label and Close Issues'
on:
schedule:
- cron: '19 4,16 * * *' # Twice daily at 19 minutes after the hour (random/uncommon time)
workflow_dispatch: # Allow manual trigger for testing
Comment thread
MichaelSimons marked this conversation as resolved.

env:
KBE_LABEL: 'Known Build Error'
Expand Down Expand Up @@ -47,6 +48,8 @@ jobs:
{ owner: context.repo.owner, repo: context.repo.repo,
labels: process.env.KBE_LABEL, state: 'open', per_page: 100 });

console.log(`Found ${issues.length} open issues with '${process.env.KBE_LABEL}' label`);

for (const issue of issues) {
if (issue.pull_request) continue;
if (issue.labels.some(l => l.name === process.env.KEEP_OPEN_LABEL)) continue;
Expand All @@ -56,14 +59,19 @@ jobs:
// |---|---|---|
// |N|N|N|
const match = issue.body?.match(
/\|24-Hour Hit Count\|.*\n\|[-| ]+\n\|(\d+)\|(\d+)\|(\d+)\|/);
if (!match) continue;
/\|24-Hour Hit Count\|.*\r?\n\|[-| ]+\r?\n\|(\d+)\|(\d+)\|(\d+)\|/);
if (!match) {
console.log(` #${issue.number}: no hit count table found`);
continue;
}
const monthCount = parseInt(match[3], 10);
console.log(` #${issue.number}: 1-month count = ${monthCount}`);

const hasStale = issue.labels.some(l => l.name === process.env.STALE_LABEL);

if (monthCount === 0 && !hasStale) {
// Zero hits for a month: mark as stale
console.log(` #${issue.number}: marking as stale`);
await github.rest.issues.addLabels({
...context.repo, issue_number: issue.number,
labels: [process.env.STALE_LABEL] });
Expand All @@ -74,6 +82,7 @@ jobs:
'Add the `' + process.env.KEEP_OPEN_LABEL + '` label to prevent auto-closure.' });
} else if (monthCount > 0 && hasStale) {
// Hits resumed: remove the stale label
console.log(` #${issue.number}: removing stale (hits resumed)`);
await github.rest.issues.removeLabel({
...context.repo, issue_number: issue.number,
name: process.env.STALE_LABEL }).catch(() => {});
Expand Down
Loading