Fix dnx not authenticating for private feeds#53322
Open
robertcoltheart wants to merge 2 commits intodotnet:release/10.0.3xxfrom
Open
Fix dnx not authenticating for private feeds#53322robertcoltheart wants to merge 2 commits intodotnet:release/10.0.3xxfrom
robertcoltheart wants to merge 2 commits intodotnet:release/10.0.3xxfrom
Conversation
Author
|
@baronfel @marcpopMSFT This is ready for review now |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51375
For
dnxexecution (dotnet tool exec), if the package source is authenticated the previous method of passing an override source meant that the credentials are lost, since this is the equivalient of passing--source https://mysourceand ignoring any config inNuGet.config. We need to pass the explicit source fordnxbecause we confirm with the user that we will be downloading from a particular source (which may be authenticated).