Skip to content

Fix Locked comment tokens to include surrounding apostrophes in FileBasedProgramsResources.resx#53180

Merged
marcpopMSFT merged 3 commits intorelease/10.0.3xxfrom
copilot/update-lock-comment-apostrophes
Feb 27, 2026
Merged

Fix Locked comment tokens to include surrounding apostrophes in FileBasedProgramsResources.resx#53180
marcpopMSFT merged 3 commits intorelease/10.0.3xxfrom
copilot/update-lock-comment-apostrophes

Conversation

Copy link
Contributor

Copilot AI commented Feb 26, 2026

The Locked comment tokens for InvalidIncludeExcludeMappingEntry and InvalidIncludeExcludeMappingExtension were missing the surrounding apostrophes that appear in the actual message text, causing translators to potentially translate the delimiters along with the literal tokens.

Changes

  • InvalidIncludeExcludeMappingEntry: {Locked="="}{Locked="'='"}
  • InvalidIncludeExcludeMappingExtension: {Locked="."}{Locked="'.'"}

The locked tokens now match the exact substrings as they appear in the message values (e.g., '.' and '='), ensuring the apostrophes are preserved untranslated.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…deMapping entries

Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot AI changed the title [WIP] Update lock comment to include apostrophes Fix Locked comment tokens to include surrounding apostrophes in FileBasedProgramsResources.resx Feb 26, 2026
@marcpopMSFT marcpopMSFT marked this pull request as ready for review February 26, 2026 23:27
Copilot AI review requested due to automatic review settings February 26, 2026 23:27
@marcpopMSFT
Copy link
Member

not sure if we have to run update xlf or not. Waiting to see if the build passes.

@marcpopMSFT
Copy link
Member

Change recommended by the translators. CC @jjonescz as an FYI.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes localization metadata in the FileBasedProgramsResources.resx file by correcting the Locked comment tokens to include surrounding apostrophes that appear in the actual message text. This ensures translators understand that the apostrophes around the delimiters '=' and '.' should not be translated, preventing potential localization errors.

Changes:

  • Updated InvalidIncludeExcludeMappingEntry locked token from {Locked="="} to {Locked="'='"} to match the exact substring in the message
  • Updated InvalidIncludeExcludeMappingExtension locked token from {Locked="."} to {Locked="'.'"} to match the exact substring in the message

<data name="InvalidIncludeExcludeMappingEntry" xml:space="preserve">
<value>Each entry in 'FileBasedProgramsItemMapping' MSBuild property must have two parts separated by '='. The entry '{0}' is invalid.</value>
<comment>{Locked="FileBasedProgramsItemMapping"}{Locked="MSBuild"}{Locked="="}</comment>
<comment>{Locked="FileBasedProgramsItemMapping"}{Locked="MSBuild"}{Locked="'='"}</comment>
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .xlf localization files need to be updated to reflect the changes in the .resx file. According to the repository's localization guidelines, you should update the .xlf files using the MSBuild target: msbuild /t:UpdateXlf on the project. This will automatically update all translation files with the new locked token annotations.

Copilot uses AI. Check for mistakes.
@marcpopMSFT
Copy link
Member

/updatexlf

@github-actions
Copy link
Contributor

▶️ XLF update workflow started. Track progress in this workflow run.

@github-actions
Copy link
Contributor

✅ XLF translation files have been updated and committed to this PR. See workflow details.

 .../xlf/FileBasedProgramsResources.cs.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.de.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.es.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.fr.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.it.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.ja.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.ko.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.pl.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.pt-BR.xlf                          | 4 ++--
 .../xlf/FileBasedProgramsResources.ru.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.tr.xlf                             | 4 ++--
 .../xlf/FileBasedProgramsResources.zh-Hans.xlf                        | 4 ++--
 .../xlf/FileBasedProgramsResources.zh-Hant.xlf                        | 4 ++--
 13 files changed, 26 insertions(+), 26 deletions(-)

@marcpopMSFT marcpopMSFT merged commit 916b9a7 into release/10.0.3xx Feb 27, 2026
24 checks passed
@marcpopMSFT marcpopMSFT deleted the copilot/update-lock-comment-apostrophes branch February 27, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants