Fix Locked comment tokens to include surrounding apostrophes in FileBasedProgramsResources.resx#53180
Conversation
…deMapping entries Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
not sure if we have to run update xlf or not. Waiting to see if the build passes. |
|
Change recommended by the translators. CC @jjonescz as an FYI. |
There was a problem hiding this comment.
Pull request overview
This PR fixes localization metadata in the FileBasedProgramsResources.resx file by correcting the Locked comment tokens to include surrounding apostrophes that appear in the actual message text. This ensures translators understand that the apostrophes around the delimiters '=' and '.' should not be translated, preventing potential localization errors.
Changes:
- Updated
InvalidIncludeExcludeMappingEntrylocked token from{Locked="="}to{Locked="'='"}to match the exact substring in the message - Updated
InvalidIncludeExcludeMappingExtensionlocked token from{Locked="."}to{Locked="'.'"}to match the exact substring in the message
| <data name="InvalidIncludeExcludeMappingEntry" xml:space="preserve"> | ||
| <value>Each entry in 'FileBasedProgramsItemMapping' MSBuild property must have two parts separated by '='. The entry '{0}' is invalid.</value> | ||
| <comment>{Locked="FileBasedProgramsItemMapping"}{Locked="MSBuild"}{Locked="="}</comment> | ||
| <comment>{Locked="FileBasedProgramsItemMapping"}{Locked="MSBuild"}{Locked="'='"}</comment> |
There was a problem hiding this comment.
The .xlf localization files need to be updated to reflect the changes in the .resx file. According to the repository's localization guidelines, you should update the .xlf files using the MSBuild target: msbuild /t:UpdateXlf on the project. This will automatically update all translation files with the new locked token annotations.
|
/updatexlf |
|
|
|
✅ XLF translation files have been updated and committed to this PR. See workflow details. |
The
Lockedcomment tokens forInvalidIncludeExcludeMappingEntryandInvalidIncludeExcludeMappingExtensionwere missing the surrounding apostrophes that appear in the actual message text, causing translators to potentially translate the delimiters along with the literal tokens.Changes
InvalidIncludeExcludeMappingEntry:{Locked="="}→{Locked="'='"}InvalidIncludeExcludeMappingExtension:{Locked="."}→{Locked="'.'"}The locked tokens now match the exact substrings as they appear in the message values (e.g.,
'.'and'='), ensuring the apostrophes are preserved untranslated.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.