Skip to content

Desync CodeOwners for dnup merge flow#53160

Merged
nagilson merged 1 commit intomainfrom
nagilson-desync-dnup-codeowners
Feb 25, 2026
Merged

Desync CodeOwners for dnup merge flow#53160
nagilson merged 1 commit intomainfrom
nagilson-desync-dnup-codeowners

Conversation

@nagilson
Copy link
Member

The intent of this is that codeowners in release/dnup does not notify others about code changes, such that the code flow from main to release/dnup doesn't trigger the pings. The codeowners file is meant to inform others about the SDK, but dnup is a separate product that others don't need to be notified about - the code change would've already made it to main in the SDK, so they've already been notified

This assumes that the codeowners file in the branch is respected by github over the one defined by main, which is what the docs suggest: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

The intent of this is that codeowners in release/dnup does not notify others about code changes, such that the code flow from `main` to `release/dnup` doesn't trigger the pings. The codeowners file is meant to inform others about  the SDK, but dnup is a separate product that others don't need to be notified about - the code change would've already made it to main in the SDK, so they've already been notified

This assumes that the codeowners file in the branch is respected by github over the one defined by `main`, which is what the docs suggest: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Copilot AI review requested due to automatic review settings February 25, 2026 20:49
@nagilson nagilson enabled auto-merge February 25, 2026 20:49
@nagilson nagilson requested a review from a team February 25, 2026 20:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the merge-flow configuration so that merges from main into release/dnup keep the target branch’s CODEOWNERS file, preventing CODEOWNERS changes from being propagated (and therefore avoiding unintended reviewer pings) when syncing SDK changes into the dnup release branch.

Changes:

  • Add CODEOWNERS to the ResetToTargetPaths list for the mainrelease/dnup merge-flow configuration.

@nagilson nagilson disabled auto-merge February 25, 2026 22:49
@nagilson
Copy link
Member Author

/ba-g no checks are running as no sdk source code was changed

@nagilson nagilson merged commit e720fab into main Feb 25, 2026
13 of 14 checks passed
@nagilson nagilson deleted the nagilson-desync-dnup-codeowners branch February 25, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants