Merged
Conversation
Member
Author
|
@dotnet/roslyn-ide ptal |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the dotnet-format project from src/BuiltInTools to src/Dotnet.Format to enable separate build configuration (Directory.Build.props/targets and editorconfig) for dotnet-watch projects without affecting dotnet-format.
Changes:
- Relocated all dotnet-format source files from
src/BuiltInTools/dotnet-format/tosrc/Dotnet.Format/dotnet-format/ - Updated project references in test projects and solution files
- Modified CODEOWNERS to reflect new path and ownership
Reviewed changes
Copilot reviewed 3 out of 78 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/dotnet-format.UnitTests/dotnet-format.UnitTests.csproj | Updated ProjectReference path to new location |
| sdk.slnx | Updated project path reference in solution |
| CODEOWNERS | Updated ownership path and maintainer assignment |
| src/Dotnet.Format/dotnet-format.slnf | Solution filter with outdated path reference |
| src/Dotnet.Format/dotnet-format/* | All dotnet-format source files moved to new location |
JoeRobich
reviewed
Feb 24, 2026
JoeRobich
approved these changes
Feb 24, 2026
This was referenced Mar 11, 2026
tmat
added a commit
to tmat/dotnet
that referenced
this pull request
Mar 12, 2026
commit 284d0a59b90b4ff852d07a1d9ee6b0b21d0b1e85
Author: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Date: Thu Mar 12 16:00:47 2026 -0700
[sdk] Source update 8cbac4a → a8c3d20
Diff: https://github.com/dotnet/sdk/compare/8cbac4a5cdf27c2bb606a282cc47e60a7c4ced45..a8c3d2038237842f6fbb33e2c12ad9a0406e40a8
From: dotnet/sdk@8cbac4a
To: dotnet/sdk@a8c3d20
[[ commit created by automation ]]
C:\sdk>darc vmr forwardflow --build 303423 --vmr C:\dotnet
info: Flowing build 20260225.4 (303423) of commit a8c3d20...
info: Making sure commit 'a8c3d2038237842f6fbb33e2c12ad9a0406e40a8' is present in repository 'C:\sdk'...
info: Flowing sdk's commit a8c3d20 to VMR at C:\dotnet...
info: Last flow was forward flow: 8cbac4a5cdf27c2bb606a282cc47e60a7c4ced45 -> 4614d82
info: Current flow is in the same direction
info: Creating a working branch darc/forward/a8c3d20-4614d82
info: Synchronizing sdk from 8cbac4a5cdf27c2bb606a282cc47e60a7c4ced45 to https://github.com/dotnet/sdk / a8c3d2038237842f6fbb33e2c12ad9a0406e40a8
info: Updating VMR sdk from 8cbac4a to a8c3d20..
info: Rebasing darc/forward/a8c3d20-4614d82 onto SdkUpdate2...
info: Resolving dependency updates in source 8cbac4a5cdf27c2bb606a282cc47e60a7c4ced45..HEAD and target 4614d82..SdkUpdate2
info: Changes staged in C:\dotnet
info: PRs from original repository included in this codeflow update:
- dotnet/sdk#53138
- dotnet/sdk#53150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other than dotnet-format
src\BuiltinToolscontains dotnet watch related projects.Move dotnet-format to
src/Dotnet.Formatand will renamesrc\BuiltinToolstosrc\Dotnet.Watch.This will allow us to define Directory.Build.props/targets and editorconfig specific to all dotnet-watch projects without affecting dotnet-format.