VirtualProjectBuilder surface cleanup#53088
VirtualProjectBuilder surface cleanup#53088tmat wants to merge 1 commit intodotnet:release/10.0.3xxfrom
Conversation
| } | ||
|
|
||
| public void CreateProjectInstance( | ||
| public ProjectInstance CreateProjectInstance(ProjectCollection projectCollection, ErrorReporter errorReporter) |
There was a problem hiding this comment.
Will be used by watch in future
There was a problem hiding this comment.
Then ErrorReporter will also need to be public. And some ErrorReporters factory methods as well, presumably. Can we perhaps just make this public when dotnet-watch needs it and we know exactly what is needed?
There was a problem hiding this comment.
I already tried that locally. We just need the ErrorReporter type.
| return GetTempSubpath(directoryName); | ||
| } | ||
|
|
||
| public static string GetVirtualProjectPath(string entryPointFilePath) |
There was a problem hiding this comment.
Will be used by watch in future.
There was a problem hiding this comment.
The project returned by CreateProjectInstance has FullPath set to this value, wouldn't that be enough for dotnet-watch?
There was a problem hiding this comment.
We need the path before creating the project.
| return GetTempSubpath(directoryName); | ||
| } | ||
|
|
||
| public static string GetVirtualProjectPath(string entryPointFilePath) |
There was a problem hiding this comment.
The project returned by CreateProjectInstance has FullPath set to this value, wouldn't that be enough for dotnet-watch?
| SourceFile sourceFile, | ||
| SyntaxTriviaList triviaList, | ||
| ErrorReporter reportError, | ||
| ErrorReporter errorReporter, |
There was a problem hiding this comment.
We should probably decide on naming and consolidate it everywhere. I think I've been renaming some parameters in the other direction (to reportError) as part of #52347.
There was a problem hiding this comment.
I renamed to avoid collision between helpers Context.ReportError and ErrorReporter ReportError field.
2 participants
No description provided.