Skip to content

Update vmr-sync images to ubuntu 2204#52992

Merged
ellahathaway merged 2 commits intodotnet:release/9.0.1xxfrom
ellahathaway:fix-image
Feb 12, 2026
Merged

Update vmr-sync images to ubuntu 2204#52992
ellahathaway merged 2 commits intodotnet:release/9.0.1xxfrom
ellahathaway:fix-image

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Feb 11, 2026

@ellahathaway ellahathaway requested review from a team as code owners February 11, 2026 23:22
Copilot AI review requested due to automatic review settings February 11, 2026 23:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the VMR synchronization Azure Pipelines job to run on Ubuntu 22.04 build images instead of Ubuntu 20.04, aligning the vmr-sync infrastructure with current 1ES pool images (per dotnet/source-build#5481).

Changes:

  • Switch the public pool image from 1es-ubuntu-2004-open to 1es-ubuntu-2204-open.
  • Switch the internal pool demand from ImageOverride -equals 1es-ubuntu-2004 to ImageOverride -equals 1es-ubuntu-2204.

@NikolaMilosavljevic
Copy link
Member

This is likely fine, but I hit an issue with 2204 image for vmr-scan job. As the image has .NET installed, InitializeDotNetCli step is not installing the local copy. My fix was in https://github.com/dotnet/sdk/pull/51725/changes

@ellahathaway
Copy link
Member Author

This is likely fine, but I hit an issue with 2204 image for vmr-scan job. As the image has .NET installed, InitializeDotNetCli step is not installing the local copy. My fix was in https://github.com/dotnet/sdk/pull/51725/changes

Thanks for calling this out :) I checked the yamls and only see references to the dotnet exe in the sync scripts:

The pwsh script looks okay, but the bash script needed to be updated. I've addressed this in 4dfccfb

@ellahathaway ellahathaway merged commit 4fac7b7 into dotnet:release/9.0.1xx Feb 12, 2026
35 of 37 checks passed
${{ if eq(variables['System.TeamProject'], 'public') }}:
name: $(DncEngPublicBuildPool)
image: 1es-ubuntu-2004-open
image: 1es-ubuntu-2204-open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I don't think 1es-ubuntu-2204-open works in public just yet, it's tracked by https://dev.azure.com/dnceng/internal/_workitems/edit/9365/

probably doesn't matter since we likely don't run vmr sync in public anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants