[dotnet test MTP]: Only use test progress when ANSI terminal#52550
Merged
Youssef1313 merged 1 commit intomainfrom Jan 20, 2026
Merged
[dotnet test MTP]: Only use test progress when ANSI terminal#52550Youssef1313 merged 1 commit intomainfrom
Youssef1313 merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the test progress reporting mechanism to only display progress when ANSI terminal capabilities are available. The changes sync with a corresponding update in the microsoft/testfx repository.
Changes:
- Simplified
TestProgressStateAwareTerminalconstructor by removing configurable update cadence parameters - Disabled progress display for non-ANSI terminals (SimpleAnsi and NonAnsiTerminal)
- Removed the
ForceAnsienum value fromAnsiModethat was only used for testing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TestProgressStateAwareTerminal.cs | Simplified constructor to only accept showProgress parameter, hardcoded ANSI update cadence to 500ms, and removed conditional progress rendering logic |
| TerminalTestReporterOptions.cs | Updated documentation to clarify progress is never shown for non-ANSI terminals, removed ForceAnsi enum value |
| TerminalTestReporter.cs | Updated constructor logic to disable progress for SimpleAnsi mode and non-ANSI terminals, simplified terminal instantiation |
mariam-abdulla
approved these changes
Jan 20, 2026
Member
Author
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with microsoft/testfx#7248