Skip to content

Update VersionFeature80 and VersionFeature90 calculations to Jan release #52495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcpopMSFT merged 2 commits into from
Feb 6, 2026
Merged

Update VersionFeature80 and VersionFeature90 calculations to Jan release #52495

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a19265
Update VersionFeature80 and VersionFeature90 calculations to Jan release
marcpopMSFT Jan 16, 2026
be1788d
Merge branch 'release/10.0.2xx' into marcpopMSFT-patch-3
marcpopMSFT Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
<VersionFeature60>36</VersionFeature60>
<VersionFeature70>20</VersionFeature70>
<!-- This version should be N-1 (ie the currently released version) in the preview branch but N-2 in main so that workloads stay behind the unreleased version -->
<VersionFeature80>23</VersionFeature80>
<VersionFeature90>12</VersionFeature90>
<VersionFeature80>$([MSBuild]::Add($(VersionFeature), 25))</VersionFeature80>
<VersionFeature90>$([MSBuild]::Add($(VersionFeature), 14))</VersionFeature90>
Comment on lines 39 to +41

Copilot AI Feb 6, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deriving VersionFeature80/90 from $(VersionFeature) means a PR that only bumps will now also implicitly change the net8/net9 runtime/targeting pack versions at build time. This can break automation/policy that treats “only changed in eng/Versions.props” as a low-impact change (e.g., .github/workflows/remove-lockdown-label.yml checks the diff for only). Consider keeping VersionFeature80/90 explicit, or updating the automation/policy to account for these derived properties so branch-lockdown behavior stays correct.

Copilot uses AI. Check for mistakes.
<!-- Should be kept in sync with VersionFeature70. It should match the version of Microsoft.NET.ILLink.Tasks
referenced by the same 7.0 SDK that references the 7.0.VersionFeature70 runtime pack. -->
<_NET70ILLinkPackVersion>7.0.100-1.23211.1</_NET70ILLinkPackVersion>
Expand Down