Fix -extra container variant check to support .NET 9+#52161
Merged
Conversation
… .NET 9/10 Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
baronfel
approved these changes
Dec 15, 2025
Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix comparison for -extra base image in ContainerFamily
Fix -extra container variant check to support .NET 9+
Dec 15, 2025
mthalman
reviewed
Jan 21, 2026
Comment on lines
+617
to
+618
| [InlineData("9.0.100", "v9.0", "noble-chiseled", "mcr.microsoft.com/dotnet/runtime:9.0-noble-chiseled-extra")] | ||
| [InlineData("10.0.100", "v10.0", "noble-chiseled", "mcr.microsoft.com/dotnet/runtime:10.0-noble-chiseled-extra")] |
Member
There was a problem hiding this comment.
Might as well cover the 8.0 case here as well.
Contributor
Author
There was a problem hiding this comment.
Added .NET 8.0 test case in commit 2397fde.
Comment on lines
+637
to
+638
| [InlineData("9.0.100", "v9.0", "noble-chiseled", "mcr.microsoft.com/dotnet/aspnet:9.0-noble-chiseled-extra")] | ||
| [InlineData("10.0.100", "v10.0", "noble-chiseled", "mcr.microsoft.com/dotnet/aspnet:10.0-noble-chiseled-extra")] |
Member
There was a problem hiding this comment.
Might as well cover the 8.0 case here as well.
Contributor
Author
There was a problem hiding this comment.
Added .NET 8.0 test case in commit 2397fde.
Co-authored-by: mthalman <15789599+mthalman@users.noreply.github.com>
auto-merge was automatically disabled
January 21, 2026 00:52
Head branch was pushed to by a user without write access
mthalman
approved these changes
Jan 21, 2026
Member
|
/backport to release/10.0.1xx |
Member
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to |
Contributor
|
Started backporting to |
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-extrabase image variant was only applied for .NET 8 due to an equality check instead of a range check, breaking support for .NET 9 and later.Changes
Fixed version comparison in
ComputeDotnetBaseImageAndTag.cs:parsedVersion.Major == FirstVersionWithNewTaggingSchemetoparsedVersion.Major >= FirstVersionWithNewTaggingScheme-extravariant containing ICU and tzdataAdded test coverage for .NET 8.0, 9.0, and 10.0:
FDDConsoleAppWithCulturesAndOptingIntoChiseledGetsExtrasForNet9AndLaterFDDAspNetAppWithCulturesAndOptingIntoChiseledGetsExtrasForNet9AndLater-extratags for current and future SDK versionsContext
The
-extravariants became available starting with .NET 8's new tagging scheme. The original implementation incorrectly hard-coded the version check to exactly 8, preventing the logic from working with newer SDK versions.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.