Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 25, 2025

This pull request updates the following dependencies

From https://github.com/microsoft/testfx

dotnet-maestro bot and others added 2 commits November 25, 2025 02:03
…251124.4

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25574.4
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25574.4
DonnaChen888 and others added 4 commits November 25, 2025 18:09
…251125.3

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25575.3
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25575.3
…251126.6

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25576.6
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25576.6
@DonnaChen888
Copy link
Contributor

Updated dependency versions in Version.Details.xml to resolve NU1109 package downgrade error in HotReload tests.
@marcpopMSFT , @nagilson Could you please review and confirm if this approach looks good?

Error:
test/Microsoft.DotNet.HotReload.Watch.Aspire.Tests/Microsoft.DotNet.HotReload.Watch.Aspire.Tests.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: Microsoft.CodeAnalysis.Features from 5.3.0-2.25560.14 to centrally defined 5.3.0-1.25568.105. Update the centrally managed package version to a higher version.
Microsoft.DotNet.HotReload.Watch.Aspire.Tests -> Microsoft.CodeAnalysis.ExternalAccess.HotReload 5.3.0-2.25560.14 -> Microsoft.CodeAnalysis.Features (= 5.3.0-2.25560.14)

…251127.6

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25577.6
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25577.6
…251128.9

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25578.9
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25578.9
dotnet-maestro bot and others added 13 commits November 30, 2025 02:01
…251128.12

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25578.12
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25578.12
…251201.5

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25601.5
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25601.5
…251202.3

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25602.3
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25602.3
…251203.1

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25603.1
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25603.1
…251204.3

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25604.3
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25604.3
@MiYanni
Copy link
Member

MiYanni commented Dec 6, 2025

This PR is showing the same problem described here: #52028 (comment)

The error log will show:

.dotnet/sdk/10.0.100/NuGet.targets(196,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) '[]' is not a valid version string.

dotnet-maestro bot and others added 2 commits December 6, 2025 02:03
…251205.6

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25605.6
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25605.6
@nagilson
Copy link
Member

nagilson commented Dec 9, 2025

This PR is showing the same problem described here: #52028 (comment)

The error log will show:

.dotnet/sdk/10.0.100/NuGet.targets(196,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) '[]' is not a valid version string.

I'm not sure how this issue #52028 (comment) is the same. This branch defines hot reload packages in both of the version.details files. That issue in 52028 also manifested as a hot reload error, not as an error in the nuget targets. With that said, it could be an issue with the NuGet packages. However, this only seems to happen on the test fx branches and I'm not seeing it pop up in other PRs, nor did I see this specific error in the history of 52028. This leads me to think it's an issue with the test fx updates.

May you help explain? Do you think fixing the nuget package source will resolve the issue?

@nagilson
Copy link
Member

nagilson commented Dec 9, 2025

Since the version string is missing, we do suspect it's a similar issue to a missing package.

SimonZhao888 and others added 2 commits December 10, 2025 09:38
…251209.4

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25609.4
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25609.4
@nagilson nagilson enabled auto-merge December 10, 2025 23:55
@nagilson
Copy link
Member

FYI @dotnet/dotnet-testing - code complete for .NET 10 is today, so if these changes are important we should really monitor this to make sure it goes through. This has been blocked from what I believe is an Arcade issue: dotnet/arcade-services#5637 but I've applied what I hope will solve as a temporary workaround.

@nagilson
Copy link
Member

nagilson commented Dec 10, 2025

Updated dependency versions in Version.Details.xml to resolve NU1109 package downgrade error in HotReload tests. @marcpopMSFT , @nagilson Could you please review and confirm if this approach looks good?

Error: test/Microsoft.DotNet.HotReload.Watch.Aspire.Tests/Microsoft.DotNet.HotReload.Watch.Aspire.Tests.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: Microsoft.CodeAnalysis.Features from 5.3.0-2.25560.14 to centrally defined 5.3.0-1.25568.105. Update the centrally managed package version to a higher version. Microsoft.DotNet.HotReload.Watch.Aspire.Tests -> Microsoft.CodeAnalysis.ExternalAccess.HotReload 5.3.0-2.25560.14 -> Microsoft.CodeAnalysis.Features (= 5.3.0-2.25560.14)

@DonnaChen888 Thanks - I appreciate your efforts here and this seemed good. This is likely due to a bug in the codeflow system which I filed above. This work around will only work temporarily, however, it's good to try to apply it to the failing branches to move stuff forward

dotnet-maestro bot and others added 2 commits December 11, 2025 02:02
…251210.8

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25610.8
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25610.8
@nohwnd
Copy link
Member

nohwnd commented Dec 11, 2025

@nagilson @DonnaChen888 those changes are not critical, they update the version of MSTest and MTP that is used to test the code in the repo. It does not get included in the shipped product. (e.g. it does not affect the MSTest templates for new projects).

This PR is okay to not merge, or merge later.

https://grep.app/search?f.repo=dotnet%2Fsdk&q=MicrosoftTestingPlatformVersion

@DonnaChen888
Copy link
Contributor

DonnaChen888 commented Dec 11, 2025

Same issue as #52053

Error:
Assert.Matches() Failure: Pattern not found in value
Regex: ".+Release\net10.0\TestProject(.dll|.exe)"···
Value: "C:\h\w\B97309BF\t\dotnetSdkTests\zyi10wu1.yi"···

DonnaChen888 and others added 3 commits December 12, 2025 09:25
…251211.7

On relative base path root
Microsoft.Testing.Platform From Version 2.1.0-preview.25571.1 -> To Version 2.1.0-preview.25611.7
MSTest From Version 4.1.0-preview.25571.1 -> To Version 4.1.0-preview.25611.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants