Skip to content

Replace line number reference with descriptive comment #51646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace line number reference with descriptive comment #51646

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d86394
Initial plan
Copilot Nov 11, 2025
e9867a1
Fix line number reference in NamedPipeServer comment
Copilot Nov 11, 2025
d2f8da7
Apply suggestion from @nohwnd
nohwnd Nov 11, 2025
0b51d97
Update src/Cli/dotnet/Commands/Test/MTP/IPC/NamedPipeServer.cs
nohwnd Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cli/dotnet/Commands/Test/MTP/IPC/NamedPipeServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public void Dispose()
// If the loop task is null at this point we have race condition, means that the task didn't start yet and we already dispose.
// This is unexpected and we throw an exception.

// To close gracefully we need to ensure that the client closed the stream line 103.
// To close gracefully we need to ensure that the client closed the stream and the InternalLoopAsync method has exited (indicated by the `// The client has disconnected` comment).
if (!_loopTask!.Wait(TimeSpan.FromSeconds(90)))
{
throw new InvalidOperationException(CliCommandStrings.InternalLoopAsyncDidNotExitSuccessfullyErrorMessage);
Expand Down
Loading