-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[release/10.0.1xx] Source code updates from dotnet/dotnet #51376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0.1xx
Are you sure you want to change the base?
[release/10.0.1xx] Source code updates from dotnet/dotnet #51376
Conversation
[[ commit created by automation ]]
…bbbf-aff67dc52e26
Updated Dependencies: dotnet-dev-certs, dotnet-user-jwts, dotnet-user-secrets, Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.NET.HostModel, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.Platforms, Microsoft.WindowsDesktop.App.Internal (Version 10.0.0-rtm.25515.111 -> 10.0.0-rtm.25520.105) Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.10.0, Microsoft.DotNet.Web.ProjectTemplates.10.0, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64, Microsoft.NETCore.App.Ref, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 10.0.0 -> 10.0.0) Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 10.0.0-preview.25515.111 -> 10.0.0-preview.25520.105) Microsoft.Build (Version 18.0.0 -> 18.0.0) Microsoft.Build.Localization (Version 18.0.0-servicing-25515-111 -> 18.0.0-servicing-25520-105) Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.0.0-rc.1611 -> 7.0.0-rc.2105) Microsoft.Build.Tasks.Git, Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 10.0.0-beta.25515.111 -> 10.0.0-beta.25520.105) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.0.0-2.25515.111 -> 5.0.0-2.25520.105) Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.25515.111 -> 2.0.0-preview.1.25520.105) Microsoft.DiaSymReader (Version 2.2.0-beta.25515.111 -> 2.2.0-beta.25520.105) Microsoft.FSharp.Compiler (Version 14.0.100-rc2.25515.111 -> 14.0.100-rc2.25520.105) Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.0.0-release-25515-111 -> 18.0.0-release-25520-105) Microsoft.TemplateEngine.Abstractions, Microsoft.TemplateEngine.Authoring.TemplateVerifier, Microsoft.TemplateEngine.Edge, Microsoft.TemplateEngine.Orchestrator.RunnableProjects, Microsoft.TemplateEngine.Utils, Microsoft.TemplateSearch.Common (Version 10.0.100 -> 10.0.100) Microsoft.TemplateEngine.Mocks, Microsoft.TemplateEngine.TestHelper, Microsoft.TemplateSearch.TemplateDiscovery (Version 10.0.100-rtm.25515.111 -> 10.0.100-rtm.25520.105) Microsoft.Web.Xdt (Version 3.2.0-preview.25515.111 -> 3.2.0-preview.25520.105) System.CommandLine (Version 2.0.0 -> 2.0.0)
…538-40e7-bbbf-aff67dc52e26
|
Same issue as #51355. |
|
Thanks for your PR, @@dotnet-maestro[bot]. |
…538-40e7-bbbf-aff67dc52e26
Updated Dependencies: dotnet-dev-certs, dotnet-user-jwts, dotnet-user-secrets, Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.NET.HostModel, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.Platforms, Microsoft.WindowsDesktop.App.Internal (Version 10.0.0-rtm.25520.105 -> 10.0.0-rtm.25520.117) Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.10.0, Microsoft.DotNet.Web.ProjectTemplates.10.0, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64, Microsoft.NETCore.App.Ref, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 10.0.0 -> 10.0.0) Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 10.0.0-preview.25520.105 -> 10.0.0-preview.25520.117) Microsoft.Build (Version 18.0.0 -> 18.0.0) Microsoft.Build.Localization (Version 18.0.0-servicing-25520-105 -> 18.0.0-servicing-25520-117) Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.0.0-rc.2105 -> 7.0.0-rc.2117) Microsoft.Build.Tasks.Git, Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 10.0.0-beta.25520.105 -> 10.0.0-beta.25520.117) Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.0.0-2.25520.105 -> 5.0.0-2.25520.117) Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.25520.105 -> 2.0.0-preview.1.25520.117) Microsoft.DiaSymReader (Version 2.2.0-beta.25520.105 -> 2.2.0-beta.25520.117) Microsoft.FSharp.Compiler (Version 14.0.100-rc2.25520.105 -> 14.0.100-rc2.25520.117) Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.0.0-release-25520-105 -> 18.0.1-release-25520-117) Microsoft.TemplateEngine.Abstractions, Microsoft.TemplateEngine.Authoring.TemplateVerifier, Microsoft.TemplateEngine.Edge, Microsoft.TemplateEngine.Orchestrator.RunnableProjects, Microsoft.TemplateEngine.Utils, Microsoft.TemplateSearch.Common (Version 10.0.100 -> 10.0.100) Microsoft.TemplateEngine.Mocks, Microsoft.TemplateEngine.TestHelper, Microsoft.TemplateSearch.TemplateDiscovery (Version 10.0.100-rtm.25520.105 -> 10.0.100-rtm.25520.117) Microsoft.Web.Xdt (Version 3.2.0-preview.25520.105 -> 3.2.0-preview.25520.117) System.CommandLine (Version 2.0.0 -> 2.0.0)
|
Important The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes. Please continue with one of the following options:
💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance. |
…538-40e7-bbbf-aff67dc52e26
…538-40e7-bbbf-aff67dc52e26
…538-40e7-bbbf-aff67dc52e26
…538-40e7-bbbf-aff67dc52e26
|
dotnet format on razor tooling timed out - let's retry. |
|
@dotnet/razor-tooling PTAL at this formatting issue, as the integration tests seem to be consistently timing out. |
…538-40e7-bbbf-aff67dc52e26
|
Maybe I'm missing something, but I don't think its possible for code in our repo to cause dotnet-format to time out, and even if it did, seems like that would be an issue for dotnet format, not us. We're just using regular old C#, I promise :) The stack seems to indicate a named pipe connection timed out opening a solution. Similar to dotnet/roslyn#80113 perhaps? @jasonmalinowski @JoeRobich ? |
|
@davidwengier That indeed looks like a duplicate; we still haven't root caused that, partly because we haven't had it repro in an environment we can debug. If this is consistent that'd be good. |
…538-40e7-bbbf-aff67dc52e26
…538-40e7-bbbf-aff67dc52e26
…538-40e7-bbbf-aff67dc52e26
|
Thanks for your response, @davidwengier. The issue only happens on razor and it happens every time in this pipeline.. so I guess the razor team is unlucky or dotnet format has some issue for the razor tooling pipeline. @jasonmalinowski May you PTAL at that (assuming you own dotnet-format?) |
…538-40e7-bbbf-aff67dc52e26
As discussed in dotnet#51376, dotnet format launches another process for doing MSBuild invocations; the issue is we're trying to talk on the named pipe to that process and it just ... never connects. This appears to be an issue thats consistent across main and 10.0.1xx at the very least and only in razor_tooling. It might be due to some workspace configuration for razor. The dotnet-format team is working on a PR, but for now to unblock we will do this.
|
We can backport #51376 once approved and then I think we can merge. Thanks for helping to investigate offline. |
As discussed in #51376, dotnet format launches another process for doing MSBuild invocations; the issue is we're trying to talk on the named pipe to that process and it just ... never connects. This appears to be an issue thats consistent across main and 10.0.1xx at the very least and only in razor_tooling. It might be due to some workspace configuration for razor. The dotnet-format team is working on a PR, but for now to unblock we will do this.
…538-40e7-bbbf-aff67dc52e26
As discussed in #51376, dotnet format launches another process for doing MSBuild invocations; the issue is we're trying to talk on the named pipe to that process and it just ... never connects. This appears to be an issue thats consistent across main and 10.0.1xx at the very least and only in razor_tooling. It might be due to some workspace configuration for razor. The dotnet-format team is working on a PR, but for now to unblock we will do this.
…538-40e7-bbbf-aff67dc52e26
|
@marcpopMSFT Once this goes in, the next backflow will have the branding update. |
…538-40e7-bbbf-aff67dc52e26
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos