Skip to content

Fix --project and --solution descriptions for dotnet test MTP to use "test" instead of "run" and extract shared localization strings #51052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Fix --project and --solution descriptions for dotnet test MTP to use "test" instead of "run" and extract shared localization strings #51052

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b68d460
Initial plan
Copilot Sep 29, 2025
4c9c63e
Fix dotnet test MTP option descriptions to use 'test' instead of 'run'
Copilot Sep 29, 2025
7d82904
Revert formatting changes, keep only functional changes
Copilot Oct 1, 2025
9587df9
Cleanup
Youssef1313 Oct 1, 2025
605166a
Address review comment
Youssef1313 Oct 2, 2025
99e653e
Extract shared localization strings for project/solution options with…
Copilot Oct 2, 2025
d8074b5
Make verb strings localizable for project/solution options
Copilot Oct 2, 2025
cecdc27
Remove unused CmdProjectDescription and CommandOptionProjectDescripti…
Copilot Oct 2, 2025
9b2267f
Update completion test snapshots with new project option description
Copilot Oct 3, 2025
504b6d2
Cleanup
Youssef1313 Oct 6, 2025
3cc26fb
Cleanup
Youssef1313 Oct 6, 2025
8b5c495
Update
Youssef1313 Oct 6, 2025
435f66c
Avoid refactoring to CommonOptions for now
Youssef1313 Oct 7, 2025
d9189db
Reduce diff
Youssef1313 Oct 7, 2025
6ca6dfb
Reduce diff
Youssef1313 Oct 7, 2025
bf21991
Add MTP help output snapshot test for dotnet test command
Copilot Oct 7, 2025
7cf2ad4
Fix MTP snapshot test to handle CI environment like other snapshot tests
Copilot Oct 7, 2025
3877d3f
ensure test snapshots make it to execution working dir
baronfel Oct 7, 2025
2b413af
Update MTPHelpSnapshotTests.VerifyMTPHelpOutput.verified.txt
Youssef1313 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/Cli/dotnet/Commands/CliCommandStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema
Expand Down Expand Up @@ -550,7 +550,7 @@ This is equivalent to deleting project.assets.json.</value>
<value>Consider packages with prerelease versions when searching for newer packages. Requires the '--outdated' option.</value>
</data>
<data name="CmdProjectDescription" xml:space="preserve">
<value>Defines the path of the project file to run (folder name or full path). If not specified, it defaults to the current directory.</value>
<value>Defines the path of the project file to run. Use path to the project file, or path to the directory containing the project file. If not specified, it defaults to the current directory.</value>
</data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot This resource is unused now? It can be deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in commit cecdc27. Deleted both CmdProjectDescription and CommandOptionProjectDescription resources as they are no longer used after switching to the parameterized CmdProjectDescriptionFormat.

<data name="CmdProjectPathName" xml:space="preserve">
<value>PROJECT_PATH</value>
Expand Down Expand Up @@ -593,12 +593,15 @@ If not specified the file will be generated inside the default 'TestResults' dir
<data name="CmdSettingsFile" xml:space="preserve">
<value>SETTINGS_FILE</value>
</data>
<data name="CmdSolutionDescription" xml:space="preserve">
<value>Defines the path of the solution file to run. If not specified, it defaults to the current directory.</value>
</data>
<data name="CmdSolutionPathName" xml:space="preserve">
<value>SOLUTION_PATH</value>
</data>
<data name="TestCmdProjectDescription" xml:space="preserve">
<value>Defines the path of the project file to test. Use path to the project file, or path to the directory containing the project file. If not specified, it defaults to the current directory.</value>
</data>
<data name="TestCmdSolutionDescription" xml:space="preserve">
<value>Defines the path of the solution file to test. Use path to the project file, or path to the directory containing the project file. If not specified, it defaults to the current directory.</value>
</data>
<data name="CmdSourceOption" xml:space="preserve">
<value>SOURCE</value>
</data>
Expand Down
4 changes: 2 additions & 2 deletions src/Cli/dotnet/Commands/Test/MTP/MicrosoftTestingPlatformOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ internal static class MicrosoftTestingPlatformOptions
{
public static readonly Option<string> ProjectOption = new("--project")
{
Description = CliCommandStrings.CmdProjectDescription,
Description = CliCommandStrings.TestCmdProjectDescription,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor nit: the strings for run and test are the same except for the 'verb' used - we've been extracting this pattern out to shared strings and providing the 'verb' as a parameter when creating the Option/Argument.

@copilot can you extract the shared loc string and update the test and run usages of the Project and Solution options to use the shared string, passing in the matching verb?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baronfel Is it fine if the words "run"/"test" are not localized? Or do we want to also have resources with "single" words for "run" and "test" so they are localized?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point - @copilot make those single words localizeable as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit 99e653e. Created parameterized resource strings CmdProjectDescriptionFormat and CmdSolutionDescriptionFormat, and factory methods CommonOptions.ProjectOption(string verb) and CommonOptions.SolutionOption(string verb). Both test and run commands now use these shared methods with their respective verbs ("test" and "run").

Test command:

--project <PROJECT_PATH>    Defines the path of the project file to test. Use path to the project file, or 
                            path to the directory containing the project file. If not specified, it 
                            defaults to the current directory.

Run command:

--project <PROJECT_PATH>    Defines the path of the project file to run. Use path to the project file, or 
                            path to the directory containing the project file. If not specified, it 
                            defaults to the current directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit d8074b5. Added localized verb resources VerbRun and VerbTest in CliCommandStrings.resx. Updated both test and run command parsers to use these localized strings instead of hardcoded "test" and "run".

Changes:

  • Created VerbRun and VerbTest resource strings
  • Updated MicrosoftTestingPlatformOptions to use CliCommandStrings.VerbTest
  • Updated RunCommandParser to use CliCommandStrings.VerbRun

The verbs are now properly localizable, ensuring consistent translations across all languages.

HelpName = CliCommandStrings.CmdProjectPathName,
Arity = ArgumentArity.ExactlyOne
};

public static readonly Option<string> SolutionOption = new("--solution")
{
Description = CliCommandStrings.CmdSolutionDescription,
Description = CliCommandStrings.TestCmdSolutionDescription,
HelpName = CliCommandStrings.CmdSolutionPathName,
Arity = ArgumentArity.ExactlyOne
};
Expand Down
19 changes: 12 additions & 7 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 12 additions & 7 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 12 additions & 7 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 12 additions & 7 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 12 additions & 7 deletions src/Cli/dotnet/Commands/xlf/CliCommandStrings.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading