Pack file-based apps as tools by default #50904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the default behavior of packing file-based apps as tools by adding PackAsTool=true to the default properties for virtual projects. This follows up on a previous change and was unblocked by a fix for a related issue.
Key changes:
- Adds
PackAsTool=trueas a default property for file-based apps - Updates test expectations to reflect the new default behavior
- Removes explicit
PackAsTool=truedirectives from tests where they are now redundant
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs |
Adds PackAsTool=true to the default properties list for virtual projects |
test/dotnet.Tests/CommandTests/Run/RunFileTests.cs |
Updates pack tests to remove explicit PackAsTool directives and adds the property to API test expectations |
test/dotnet.Tests/CommandTests/Project/Convert/DotnetProjectConvertTests.cs |
Updates all project conversion tests to include PackAsTool=true in expected outputs and test patterns |
Member
Author
|
@RikkiGibson @333fred @MiYanni for reviews, thanks |
RikkiGibson
approved these changes
Sep 18, 2025
333fred
approved these changes
Sep 18, 2025
baronfel
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #50168.
Unblocked by a fix of #50435.