Skip to content

Update compatibility message for targeting .NET 10.0 in Visual Studio 18.0 #50749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+72 −70
Open

Update compatibility message for targeting .NET 10.0 in Visual Studio 18.0 #50749

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
237357f
Initial plan
Copilot Sep 11, 2025
bd1ca9b
Update compatibility message for trying to target net10.0 in VS 17.14
Copilot Sep 11, 2025
ab74179
Update .NET 10.0 compatibility warning to require VS 18.0
Copilot Sep 11, 2025
b05f036
Move the latest message to the end of the file so it'll trigger merge…
marcpopMSFT Sep 15, 2025
f6c878c
Update helix test queues to use VS 2026 images
Copilot Oct 17, 2025
99c06be
Update NETSDK error code from 1229 to 1233 to resolve merge conflict
Copilot Oct 17, 2025
8ab9f6c
Merge branch 'main' into copilot/fix-50748
marcpopMSFT Oct 17, 2025
3e05870
Remove unused Net9NotCompatibleWithDev1711 resource
Copilot Oct 19, 2025
37dc93a
Skip AOT tests failing on VS 2026 image
Copilot Oct 20, 2025
860bf5c
Update tests for VS 18 compatibility and NETSDK1223 removal
Copilot Oct 20, 2025
97ae8c4
Revert RulesMissingDocumentation.md and fix 4.6.2 test parameters
Copilot Oct 20, 2025
28d3a8a
Move to earlier than 17.15
marcpopMSFT Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1225: Native compilation is not supported when invoking the Publish target directly. Try running dotnet publish.</value>
<comment>{StrBegins="NETSDK1225: "}</comment>
</data>
<!-- The latest message added is PrunePackageDataNotFound. Please update this value with each PR to catch parallel PRs both adding a new message -->
<!-- The latest message added is Net10NotCompatibleWithVS1713. Please update this value with each PR to catch parallel PRs both adding a new message -->
<data name="PrunePackageDataNotFound" xml:space="preserve">
<value>NETSDK1226: Prune Package data not found {0} {1} {2}. To ignore this error, set the AllowMissingPrunePackageData to true.</value>
<comment>{StrBegins="NETSDK1226: "}</comment>
Expand All @@ -995,4 +995,8 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1228: This project depends on the Aspire Workload which has been deprecated. Aspire now ships via NuGet packages and no longer requires a workload. Please visit {0} for upgrade guidance.</value>
<comment>{StrBegins="NETSDK1228: "}</comment>
</data>
<data name="Net10NotCompatibleWithVS1713" xml:space="preserve">
<value>NETSDK1229: Targeting .NET 10.0 or higher in Visual Studio 2022 17.14 is not supported.</value>
<comment>{StrBegins="NETSDK1229: "}</comment>
</data>
</root>
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,10 +138,10 @@ Copyright (c) .NET Foundation. All rights reserved.
FormatArguments="$(SdkResolverGlobalJsonPath)" />
</Target>

<Target Name="_WarnWhenUsingNET9AndVSPriorTo1712"
<Target Name="_WarnWhenUsingNET10AndVSPriorTo1714"
BeforeTargets="_CheckForInvalidConfigurationAndPlatform"
Condition="$([MSBuild]::VersionLessThan($(MSBuildVersion), '17.12.0')) and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '9.0'))">
<NetSdkWarning ResourceName="Net9NotCompatibleWithDev1711"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Net9NotCompatibleWithDev1711 resource be deleted from resx?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Net9NotCompatibleWithDev1711 is not longer used so please remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the unused Net9NotCompatibleWithDev1711 resource from Strings.resx and all localization files. Changes committed in the commit shown above.

Condition="$([MSBuild]::VersionLessThan($(MSBuildVersion), '17.14.0')) and '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and $([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '10.0'))">
<NetSdkWarning ResourceName="Net10NotCompatibleWithVS1713"/>
</Target>

<Target Name="_CheckForInvalidWindowsDesktopTargetingConfiguration"
Expand Down