Remove NETStandard.Library.Ref from Version.Details.xml/.props #50533
Conversation
This won't get updated anymore and we're already setting/overriding NETStandardLibraryRefPackageVersion in Versions.props
|
This PR is targeting |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the NETStandard.Library.Ref dependency from version tracking files as it's no longer being updated and the version is already managed elsewhere in the build configuration.
- Removes the NETStandard.Library.Ref dependency entry from Version.Details.xml
- Removes the corresponding package version properties from Version.Details.props
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Version.Details.xml | Removes the NETStandard.Library.Ref dependency definition with its pinned version and repository information |
| eng/Version.Details.props | Removes the NETStandardLibraryRefPackageVersion property and its corresponding version alias |
| <SystemTextJsonPackageVersion>10.0.0-rc.2.25416.109</SystemTextJsonPackageVersion> | ||
| <SystemWindowsExtensionsPackageVersion>10.0.0-rc.2.25416.109</SystemWindowsExtensionsPackageVersion> | ||
| <!-- dotnet/core-setup dependencies --> | ||
| <NETStandardLibraryRefPackageVersion>2.1.0</NETStandardLibraryRefPackageVersion> |
There was a problem hiding this comment.
Removing this would break the bundled versions generation I think. with the property empty, the build will pass, but it will write a blank and then later use that as a version number at compile time when building a project that targets 2.1
There was a problem hiding this comment.
The property won't be empty since we set it here:
Line 84 in 6ed21da
There was a problem hiding this comment.
doh, I forgot we split out the props recently. nvm
This won't get updated anymore and we're already setting/overriding NETStandardLibraryRefPackageVersion in Versions.props