Fix handshaking of dotnet test for MTP #50513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR is targeting |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes handshaking issues between dotnet test and the Microsoft Testing Platform (MTP) by adding protocol version validation and improving handshake failure handling.
- Adds validation to ensure MTP supports the required protocol version 1.0.0
- Fixes terminal formatting logic for target framework and architecture display
- Adds workaround to ignore handshake failures during help command execution
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TestApplicationEventHandlers.cs | Adds protocol version validation and moves testApplication variable declaration |
| TerminalTestReporter.cs | Fixes terminal formatting bug and adds help command handshake failure workaround |
Co-authored-by: Copilot <[email protected]>
mariam-abdulla
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.