Fix some error messages in dotnet test #50393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes error messages in the dotnet CLI by adding a new localized string TestCommandExceptionUnableToRun and updating the error handling logic for test command execution. The changes improve error messaging consistency between run and test commands.
- Adds a new localized error message specifically for test command execution failures
- Updates error handling logic to use the correct error message for test scenarios
- Refactors run properties handling to separate test platform applications from VSTest projects
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Adds new TestCommandExceptionUnableToRun error message string |
| src/Cli/dotnet/Commands/xlf/*.xlf | Auto-generated localization files with new error message translations |
| src/Cli/dotnet/Commands/Test/SolutionAndProjectUtility.cs | Updates error handling to use test-specific error message and improves run properties logic |
| src/Cli/dotnet/Commands/Run/RunProperties.cs | Refactors to extract common error handling logic and use appropriate error messages |
mariam-abdulla
changed the title
Youssef1313
reviewed
Aug 21, 2025
Youssef1313
reviewed
Aug 21, 2025
Youssef1313
reviewed
Aug 21, 2025
jjonescz
reviewed
Aug 21, 2025
jjonescz
reviewed
Aug 21, 2025
Youssef1313
reviewed
Aug 21, 2025
jjonescz
approved these changes
Aug 21, 2025
Youssef1313
approved these changes
Aug 21, 2025
Member
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/17127212696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling and messaging for the
dotnet testcommand, especially when a project is not runnable or is misconfigured. It introduces a new error message for test command failures, refactors how run properties are retrieved, and ensures consistency in error reporting across different scenarios. Additionally, translations for the new error message have been added for multiple languages.Error handling and messaging improvements:
TestCommandExceptionUnableToRunfor cases wheredotnet testcannot proceed due to project misconfiguration, including details about the project, command, property, and current value. This message is now used instead of the generic run error in test scenarios. [1] [2]TestCommandExceptionUnableToRunin all supported languages, ensuring consistent messaging for global users. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Code refactoring and logic changes:
RunProperties.GetPropsFromProjectandRunProperties.ThrowUnableToRunErrormethods to centralize and clarify how run properties and related errors are handled for test projects.SolutionAndProjectUtilitylogic to only retrieve run properties for platform test applications and to create minimal run properties for VSTest projects, improving robustness and clarity. [1] [2]GetPropsFromProjectmethod instead of the previousFromProjectmethod, aligning with the new error handling flow.