Add the missing netcore installer to the bundle #50351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #50079 by adding a missing .NET Core installer package to the MSI bundle generation process. The change ensures that the NetCore App Targeting Pack installer is included alongside other downloaded installer components.
- Adds the missing
DownloadedNetCoreAppTargetingPackInstallerFileNameto the_DotNetMsiPackagescollection
Member
Author
|
/backport to release/10.0.1xx-rc1 |
Contributor
|
Started backporting to release/10.0.1xx-rc1: https://github.com/dotnet/sdk/actions/runs/17050466084 |
Member
Author
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/sdk/actions/runs/17050485555 |
joeloff
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50079
I checked and all of the other <downloaded* items appear to be included so this is the only one missing.