Skip to content
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
5597 commits
Select commit Hold shift + click to select a range
6f26008
Merge pull request #6968 from mpidash/ca1846-fix-typo
mavasani Oct 4, 2023
8f3b2fd
Merge pull request #6873 from Youssef1313/Ca1824-no-comp-end
mavasani Oct 11, 2023
d0d0658
Fix false-flag of CompareExchange and re-usage with loops (#6979)
jozkee Oct 13, 2023
3622ffa
Merge branch 'master' into issue_6652
CollinAlpert Oct 15, 2023
9c4bd8b
Apply PR comments
CollinAlpert Oct 15, 2023
963fedd
Merge pull request #6683 from CollinAlpert/issue_6652
mavasani Oct 16, 2023
303e57e
Merge branch 'master' into issue_336
CollinAlpert Oct 16, 2023
f440020
Apply PR comments.
CollinAlpert Oct 16, 2023
1d63a03
Do not raise CA1065 when in delegate
CollinAlpert Oct 17, 2023
86e2ee7
Only include equal or more accessible methods
david-acker Oct 21, 2023
c78cbce
Handle accessibility correctly in inheritance scenarios
david-acker Oct 22, 2023
6f8a2e5
Remove unnecessary if
david-acker Oct 22, 2023
6caa2f9
Merge branch 'master' into issue_336
CollinAlpert Oct 25, 2023
b15190e
Don't emit CA1849 for nameof expressions
CollinAlpert Oct 29, 2023
b3c8b29
Merge pull request #7010 from CollinAlpert/issue-6993
mavasani Oct 30, 2023
c93aec0
Merge pull request #6779 from CollinAlpert/issue_336
mavasani Oct 30, 2023
f6ee900
Apply PR comments
CollinAlpert Oct 30, 2023
ff5feda
Merge branch 'master' into issue_6963
CollinAlpert Oct 30, 2023
f7c0c8f
Merge pull request #6986 from CollinAlpert/issue_6963
mavasani Oct 30, 2023
4f70156
Generate unique name for CA1861
CollinAlpert Oct 30, 2023
5a68335
Don't emit CA1508 in Debug.Assert
CollinAlpert Oct 30, 2023
515ba69
Remove unnecessary using
CollinAlpert Oct 30, 2023
2b834f0
Merge pull request #7013 from CollinAlpert/issue-6981
mavasani Oct 31, 2023
20b6b3d
docs(grammatical): correct typos
Abhineshhh Oct 31, 2023
f7b1036
Merge pull request #7016 from AbhineshJha/typo
mavasani Nov 1, 2023
12eb45f
Merge branch 'main' into bug/CA1307-overload-accessibility
david-acker Nov 1, 2023
35883e4
CA2241: Non supported heuristically found format methods should not b…
manfred-brands Nov 2, 2023
7543dac
CA2213:Disposable fields should be disposed and support for `DisposeC…
MartyIX Nov 8, 2023
cb2c00a
Fix doc link
gewarren Nov 16, 2023
ffa4962
fix grammar in CA2261 message
gewarren Nov 17, 2023
39b69be
Revert "fix grammar in CA2261 message"
gewarren Nov 17, 2023
e54fac3
fix grammar in CA2261 message
gewarren Nov 17, 2023
141d73d
Merge pull request #7038 from gewarren/patch-1
mavasani Nov 17, 2023
fa35851
Don't report diagnostic when ISerializable is inherited (#6997)
david-acker Nov 18, 2023
b94c11c
Don't raise CA1861 in for attribute arguments
CollinAlpert Nov 19, 2023
1caec67
Support banning base types
aelij Nov 22, 2023
4202020
Remove flagging target (#7040)
carlossanlop Nov 22, 2023
09d0523
Don't emit CA1849 for IDbContextFactory.CreateDbContext
CollinAlpert Nov 26, 2023
0cac5a1
Pass method name to GetMembers
CollinAlpert Nov 27, 2023
2c77c32
Merge pull request #7058 from CollinAlpert/issue-7036
mavasani Nov 27, 2023
2c43d71
Merge pull request #7052 from aelij/feature/banned-base-types
mavasani Nov 29, 2023
6df0075
Merge pull request #7024 from manfred-brands/Issue7023_CA2241_IFormat…
mavasani Nov 29, 2023
a954f29
Merge pull request #7014 from CollinAlpert/issue-6983
mavasani Nov 29, 2023
ea8e4f8
update rules missing docs
gewarren Nov 29, 2023
073f4c8
Don't raise RS1039 when passing LocalFunctionStatementSyntax
CollinAlpert Nov 30, 2023
c9e4bb2
Merge pull request #7044 from CollinAlpert/issue-7033
mavasani Nov 30, 2023
72c3f56
Merge pull request #7062 from CollinAlpert/issue-7061
mavasani Nov 30, 2023
1659b8b
Remove call to LookupSymbols
david-acker Dec 1, 2023
88f5c2d
Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/Spec…
david-acker Dec 1, 2023
e8b0092
Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/Spec…
david-acker Dec 1, 2023
f5064c8
Use SemanticModel on IInvocationOperation
david-acker Dec 1, 2023
891fac6
Merge pull request #6998 from david-acker/bug/CA1307-overload-accessi…
mavasani Dec 1, 2023
1836087
Edit from msbuild pack command
mavasani Dec 4, 2023
5b91aaa
Merge pull request #7039 from gewarren/option
mavasani Dec 4, 2023
2da72ad
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Dec 8, 2023
1f0098d
Merge pull request #7076 from dotnet/locfiles/e3610918-d3dc-45b8-81a0…
github-actions[bot] Dec 8, 2023
633b859
Suppress CA1860 when in expression tree
CollinAlpert Dec 8, 2023
8a396b5
Suppress CA1725 for generic parameters
CollinAlpert Dec 8, 2023
c3b811a
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Dec 9, 2023
ea471bd
Merge pull request #7081 from dotnet/locfiles/ad2c9503-5f37-4ecc-9a26…
github-actions[bot] Dec 9, 2023
b88968e
Suppress CA1862 for string.Contains on netfx
CollinAlpert Dec 9, 2023
c4eccc4
Update RulesMissingDocumentation.md
CollinAlpert Dec 9, 2023
365aacb
Remove extra space
joegoldman2 Dec 9, 2023
62f0130
Merge pull request #7084 from joegoldman2/extra-space
mavasani Dec 11, 2023
546a35c
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Dec 11, 2023
c02adcb
Merge pull request #7083 from CollinAlpert/issue-7053
mavasani Dec 11, 2023
074c3b9
Merge pull request #7089 from dotnet/locfiles/23fea615-4b2c-4943-8c39…
github-actions[bot] Dec 11, 2023
6aaf382
Merge pull request #7077 from CollinAlpert/suppress-ca1725-for-generics
mavasani Dec 11, 2023
0c18bcb
fix(CA2208): false positive when message start with parameter name fo…
HenryZhang-ZHY Dec 11, 2023
668b2bc
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Dec 13, 2023
dcd274f
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Dec 13, 2023
4a2d455
Merge pull request #7094 from dotnet/locfiles/67630858-e20c-4cff-9877…
github-actions[bot] Dec 13, 2023
2e36e15
Preserve code style during fix
sharwell Dec 19, 2023
637e851
Merge pull request #7107 from sharwell/preserve-style
sharwell Dec 27, 2023
f0dafca
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Dec 27, 2023
f652570
Merge pull request #7117 from dotnet/locfiles/c3437a29-9755-46ca-b7fa…
github-actions[bot] Dec 27, 2023
32c55f8
Implement RS1041 (Compiler extensions should be implemented in assemb…
sharwell Dec 22, 2023
ade494b
Avoid using SyntaxReference.GetSyntaxAsync
sharwell Dec 28, 2023
be07c62
Provide WellKnownTypeProvider through CodeMetricsAnalysisContext
sharwell Dec 28, 2023
2b8a627
Avoid captures in AddCoupledNamedTypesCore
sharwell Dec 28, 2023
1e4dce2
Avoid string split allocations in GetLinesOfCode
sharwell Dec 28, 2023
9af2b29
Avoid delegate allocations in GetSemanticModel
sharwell Dec 28, 2023
36bf341
Avoid enumerator allocations calling AddCoupledNamedTypes
sharwell Dec 28, 2023
94f58b4
Avoid parallel code metrics calculations within a single member
sharwell Dec 28, 2023
7c67883
Avoid parallel code metrics calculations in the analyzer pipeline
sharwell Dec 28, 2023
e433e01
Cancel code metrics calculation when requested
sharwell Dec 28, 2023
daaaa85
Create fix for CA1861 in top level statements
CollinAlpert Dec 29, 2023
1213d0c
Add code metrics tests for other line ending styles
sharwell Dec 29, 2023
f80d7fd
Remove non-standard helper NormalizeLineEndings
sharwell Dec 29, 2023
e3dc79f
Add tests covering properties and events
sharwell Dec 29, 2023
f0676cc
fix 6982
daveMueller Dec 29, 2023
f5883ef
Merge pull request #7119 from CollinAlpert/issue-7111
mavasani Jan 2, 2024
58654f4
Merge pull request #7120 from daveMueller/issue-6982
mavasani Jan 2, 2024
324b919
Merge pull request #6966 from reduckted/feature/5818
mavasani Jan 2, 2024
9408484
Merge pull request #7118 from sharwell/metrics-perf
sharwell Jan 2, 2024
5ad8e9a
Fix indentation
CollinAlpert Jan 4, 2024
acf8847
Merge pull request #7123 from CollinAlpert/issue-7063
mavasani Jan 9, 2024
3d6c0bb
Merge pull request #7116 from sharwell/check-target-framework
sharwell Jan 9, 2024
4a34b54
Fix a number of issues in CA1859.
Jan 10, 2024
9d51945
Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/…
geeknoid Jan 11, 2024
b46cb1e
Make AnalyzerOptionsExtensions to have public modifier instead of int…
eriawan Dec 9, 2023
86d45fc
Set some classes modifiers to public
eriawan Dec 13, 2023
3fbfc66
Suppress CA1034 on NameParts class
eriawan Dec 13, 2023
3457089
Handle explicit interface implementations of Equals
david-acker Jan 12, 2024
9e5ba65
Handle explicit interface implementations of GetHashCode
david-acker Jan 12, 2024
b421697
Allow static virtual members in CA1000
RenderMichael Jan 13, 2024
279cd6c
Add MSBUILD compile constants (preprocess symbol) in Test.Uitilities.…
eriawan Jan 13, 2024
0d5f5fc
Ad ifdef in test instead of expecting a failure
RenderMichael Jan 15, 2024
eb80f3b
remove unnecessary generic
RenderMichael Jan 15, 2024
19d046d
Bring back generic
RenderMichael Jan 15, 2024
f0b247f
use generic type
RenderMichael Jan 15, 2024
a0a30bd
Merge pull request #7085 from eriawan/make-AnalyzerOptionsExtensions-…
mavasani Jan 16, 2024
9ac7f01
Specify C# 11 and protect against .NET 7 warnings
RenderMichael Jan 16, 2024
cff6cb9
Specify .NET 6
RenderMichael Jan 16, 2024
50014ec
Merge pull request #7140 from david-acker/bug-CA1065-explicit-interfa…
mavasani Jan 16, 2024
dcc3306
Merge pull request #7142 from RenderMichael/main
mavasani Jan 16, 2024
f39318d
Add another test case
Jan 17, 2024
3e1c32d
Merge branch 'main' of https://github.com/geeknoid/roslyn-analyzers
Jan 17, 2024
50ecf0f
Merge pull request #7133 from geeknoid/main
mavasani Jan 17, 2024
dbd3c42
[main] Update dependencies from dotnet/arcade (#7149)
dotnet-maestro[bot] Jan 22, 2024
4aa823d
Fix grammar for CA2262's description (#7169)
gewarren Feb 1, 2024
5fab7e0
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Feb 1, 2024
e4c027d
Merge pull request #7172 from dotnet/locfiles/f41dd505-ecae-42e9-a571…
github-actions[bot] Feb 2, 2024
d70dc1e
In PlatformCompatiblityAnalyzer, set ObsoleteUrl based on child Obsol…
omajid Feb 2, 2024
b0ccb1b
Unified Build control update (#7184)
mmitche Feb 9, 2024
65b9394
Add IsFileLocal lightup, use it in `CA1708`
RenderMichael Feb 12, 2024
6c3ec58
Fix nullability
RenderMichael Feb 13, 2024
7eb6d2d
Use the style of other lightup types
RenderMichael Feb 13, 2024
8e5c805
Formatting
RenderMichael Feb 13, 2024
0b9d9ba
PR feedback
RenderMichael Feb 14, 2024
9963c17
PR feedback
RenderMichael Feb 14, 2024
d08f414
Cleanup
RenderMichael Feb 14, 2024
cd7b45a
Further PR feedback
RenderMichael Feb 14, 2024
ca52e98
Add [WorkItem] attribute
RenderMichael Feb 14, 2024
f2a1b5f
fix CA2021 false positives (#7183)
fowl2 Feb 15, 2024
6dbb147
CA2263: Prefer generic overload when type is known (#6857)
mpidash Feb 16, 2024
faaa6ae
Merge branch 'dotnet:main' into main
RenderMichael Feb 17, 2024
51d9cac
Merge pull request #7190 from RenderMichael/main
sharwell Feb 17, 2024
a875804
Warn about ignored method result for IQueryable (#7182)
CollinAlpert Feb 22, 2024
b6a6166
Enhance: Inline variable in CA1854 (IDictionary.TryGetValue) (#7071)
Poker-sang Feb 23, 2024
529df51
Add DoNotPassStructToArgumentNullExceptionThrowIfNullAnalyzer (#6815)
CollinAlpert Feb 23, 2024
0e9bd93
Don't report CA2257 on nested types (#7157)
jkoritzinsky Feb 27, 2024
a4deba4
CA1065: Ignore System.Diagnostics.UnreachableException (#7200)
mpidash Feb 27, 2024
2a545e9
Emit diagnostic for 'is' pattern
CollinAlpert Feb 28, 2024
67be5e8
Support collection expressions for non-copyable analyzer (#7210)
333fred Feb 28, 2024
a82c0fa
Allow fixer to fix 'is' patterns.
CollinAlpert Feb 28, 2024
4b0b436
Fix spacing.
CollinAlpert Feb 28, 2024
7300269
Add WorkItem attribute
CollinAlpert Feb 28, 2024
17f9e1c
Add explanatory comments
CollinAlpert Mar 1, 2024
7b5539c
Merge pull request #7213 from CollinAlpert/issue-7207
mavasani Mar 1, 2024
1a9d333
Remove temporary .NET 8 reference assemblies
mpidash Mar 1, 2024
289071b
Create DoNotCompareSpanToNullAnalyzer (#6838)
CollinAlpert Mar 5, 2024
5fd72ec
Merge pull request #7220 from mpidash/issue-6923
mavasani Mar 5, 2024
aed145b
Add ClassName property to ResxSourceGenerator
raulsntos Mar 6, 2024
c0a0d49
Add UseVolatileReadWriteAnalyzer (#7043)
CollinAlpert Mar 12, 2024
3dd2e56
CA2263: Fix wrong fix for notnull constraints and fix crash on unboun…
mpidash Mar 16, 2024
16976cf
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Mar 16, 2024
975171e
Merge pull request #7248 from dotnet/locfiles/406d3ea0-8e3b-4d48-8170…
github-actions[bot] Mar 16, 2024
7af53fe
Add CA1872: Prefer 'Convert.ToHexString' over 'BitConverter.ToString'…
mpidash Mar 19, 2024
bbbd766
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Mar 25, 2024
f0f598d
Merge pull request #7266 from dotnet/locfiles/296991ce-c7f1-4b02-84d7…
github-actions[bot] Mar 25, 2024
06db8f5
Add CA2022: Avoid inexact read with 'Stream.Read' (#7208)
mpidash Mar 26, 2024
2cb0578
CA2022: Do not flag well known reliable stream types (#7269)
mpidash Mar 26, 2024
1390d23
Specify IEqualityComparer when creating well known type set (#7270)
mpidash Mar 27, 2024
cf75067
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Apr 1, 2024
32eef5b
Merge pull request #7273 from dotnet/locfiles/ab194c92-23d1-47fc-bdbf…
github-actions[bot] Apr 1, 2024
9e27d4c
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
dotnet-bot Apr 2, 2024
4cacdd3
Merge pull request #7276 from dotnet/locfiles/2c8e5342-1a3f-4857-9b60…
github-actions[bot] Apr 2, 2024
1dd79fa
Add CollectionExpression support to CA1870 (UseSearchValues) (#7252)
MihaZupan Apr 3, 2024
fda284d
Check for the CollectionExpression syntax kind early in UseSearchValu…
MihaZupan Apr 9, 2024
9bde73f
Do not emit CA1854/CA1864 for nested conditionals (#7228)
CollinAlpert Apr 12, 2024
bad627a
Fix some typos
raulsntos Apr 18, 2024
de56158
Merge pull request #7298 from raulsntos/typos
Evangelink Apr 25, 2024
a7ab488
Prevent SemaphoreSlim.Wait(0) from triggering CA1849
CollinAlpert May 10, 2024
2488542
Remove unnecessary using
CollinAlpert May 10, 2024
3415e4b
Fix formatting
CollinAlpert May 10, 2024
5f6ab30
Apply code review suggestions.
CollinAlpert May 18, 2024
d08b23b
Remove unnecessary using.
CollinAlpert May 18, 2024
4230ef6
Add Debug.Assert
CollinAlpert May 18, 2024
b322e02
Merge pull request #7226 from raulsntos/resx-generator-class-name
sharwell May 22, 2024
89ddfb4
Merge pull request #7310 from CollinAlpert/issue-7271
sharwell Jun 4, 2024
8dd02c1
Mark type as instantiated when used with a collection expression init…
CollinAlpert Jun 7, 2024
b1708c3
Generate field for const arrays in constructor declarations (#7231)
CollinAlpert Jun 7, 2024
49b195a
Do not warn when invoking APIs that has SupportedOSPlatformGuard attr…
buyaa-n Jun 14, 2024
0f7475e
Update to Microsoft.CodeAnalysis.Testing 1.1.2-beta1.24314.1
sharwell Jun 18, 2024
cb2aaf2
Merge pull request #7333 from sharwell/update-testing
sharwell Jun 18, 2024
b020904
Don't emit CA1064 in executables (#7234)
CollinAlpert Jun 24, 2024
6211e28
Highlight C# code in unit tests
JakeYallop Jun 25, 2024
5c59767
Test
MartyIX Jul 7, 2024
9a243a3
Fix
MartyIX Jul 7, 2024
d9a3d7b
Execute NameAndParametersValid only when needed. (#7353)
mandel-macaque Jul 15, 2024
5c1dc52
Add additional StringSyntax attributes
JakeYallop Jul 24, 2024
ffb7081
Merge pull request #7335 from JakeYallop/add-string-syntax-attribute
Evangelink Aug 2, 2024
66a7d4f
Merge pull request #7347 from MartyIX/feature/2024-07-07-CA2213-override
Evangelink Aug 6, 2024
d29f7f5
Bump main to 10.0 (#7379)
carlossanlop Aug 15, 2024
f058812
Temporarily disable pragma SYSLIB0014 from CSharp CodeFix Verifiers (…
carlossanlop Aug 21, 2024
4784c04
fix(CA2023: Adds validation against invalid braces in logger message …
Kritner Aug 23, 2024
10f410f
CA1854: Use unused variable name for out parameter (#7261)
mpidash Aug 26, 2024
d9baf6a
Update AnalyzerReleases file to reflect new analyzers for .NET9 relea…
buyaa-n Aug 28, 2024
92d845e
Emit CA1305 for more nullable types. (#7306)
CollinAlpert Aug 29, 2024
9179a33
Do not suggest passing IFormatProvider to certain Convert methods (#7…
CollinAlpert Aug 30, 2024
c499400
ExcludeFromSourceBuild->ExcludeFromSourceOnlyBuild (#7414)
mmitche Sep 17, 2024
5e9c6e0
Add an analyzer for Debug.Assert (#7416)
333fred Sep 26, 2024
125e2e8
Update field references (#7430)
cston Oct 3, 2024
b124297
Fix CA1850 Fixer not accounting for toplevel syntax nodes (#7400)
wzchua Oct 8, 2024
061b0ee
Fix false positive for CA1854 across instances (#7309)
CollinAlpert Oct 16, 2024
d70813d
Add CA2024: Do not use 'StreamReader.EndOfStream' in async methods (#…
mpidash Nov 9, 2024
b534ec1
Add test case for #7357.
danpere Nov 27, 2024
bcdfbce
Avoid .OriginalDefinition for comparing class types.
danpere Nov 27, 2024
26ca785
Add AdditionalFiles.NoWarn metadata
dvoituron Dec 1, 2024
a3fdb84
Fix CA2021 false positive for generic class types (7488)
JoeRobich Dec 3, 2024
4d7ea5c
Merge pull request #7489 from dvoituron/users/dvoituron/resxsourcegen…
sharwell Dec 3, 2024
0bb1b1e
Replace analyzerunner wiki with publicly accessible markdown
arunchndr Dec 5, 2024
c4d5bb1
Merge pull request #7498 from dotnet/arunchndr-patch-1
arunchndr Dec 5, 2024
b62443f
Error when users use a `file` type for things we need to load (#7501)
333fred Dec 16, 2024
3e2e39e
Ensure that PlatformCompatibilityAnalyzer better handles various TFMs…
tannergooding Jan 22, 2025
63e68aa
Trim leading v from TargetFrameworkVersion (#7544)
tannergooding Jan 23, 2025
f581b4c
Add CA1873: Avoid potentially expensive logging (#7290)
mpidash Jan 31, 2025
df7f2c7
Upgrade CodeAnalysisVersion consistently (#7560)
ViktorHofer Feb 25, 2025
267d1af
Fix two more cases where the live CodeAnalysis version isn't used (#7…
ViktorHofer Feb 26, 2025
03373ea
Add analyzers for Regex.Match(...).Success and Regex.Matches(...).Cou…
stephentoub Feb 27, 2025
2d431c2
React to breaking api change
CyrusNajmabadi Feb 27, 2025
ad2b38f
Merge pull request #7589 from dotnet/compile
CyrusNajmabadi Feb 27, 2025
66bb69f
Move roslyn owned analyzers to the Roslyn repo.
JoeRobich Mar 17, 2025
15ce490
Move files to the projects that were linking them in.
JoeRobich Mar 22, 2025
4927471
[main] Update dependencies from dotnet/arcade (#7602)
dotnet-maestro[bot] Mar 27, 2025
0a6d3c1
Merge pull request #7603 from dotnet/dev/jorobich/remove-roslyn-packages
JoeRobich Mar 28, 2025
2867225
Update CA2241 to support user-defined StringSyntaxAttribute
sharwell Apr 21, 2025
3f97bd4
Add tests for multiple StringSyntaxAttribute definitions
sharwell Apr 21, 2025
84fc08c
CA2025 Do not pass `IDisposable` instances into unawaited tasks (#7549)
steveberdy Apr 27, 2025
c65815d
fix CA2021 false positive casting from value type constraint to Enum …
fowl2 Apr 27, 2025
cabd14d
CA2251: support for string.CompareOrdinal (#7594)
allantargino Apr 27, 2025
53d9599
Merge pull request #7632 from sharwell/api-by-name
sharwell Apr 28, 2025
bea7985
Fix missing quotes
trympet May 30, 2025
a99d420
escape period with backslash
trympet Jun 5, 2025
483fca0
Make CA2025 DoNotPassDisposablesIntoUnawaitedTasks analyzer opt-in (#…
akoeplinger Jun 16, 2025
b88dcdb
Handle guarded maccatalyst attribute issue that suppressed by call si…
buyaa-n Jun 20, 2025
1551bee
Don't report CA1861 if the highest initializer is a static member (#7…
steveberdy Jun 20, 2025
dfeef6d
Handle extension members by 'make member static' (#7739)
jjonescz Jul 25, 2025
29bd87c
Add a basic fixer to suggest replacing intrinsics with their cross-pl…
tannergooding Jul 26, 2025
b50dffa
Merge branch 'main' of ../roslyn-analyzers into MoveRoslynAnalyzersToSdk
ViktorHofer Jul 28, 2025
a84c83f
Delete unused refactoring utilities sources
ViktorHofer Jul 29, 2025
2f563c4
Merge remote-tracking branch 'origin/main' into MoveRoslynAnalyzersToSdk
ViktorHofer Aug 11, 2025
89b70f0
Integration NetAnalyzers into sdk build and make everything build
ViktorHofer Aug 11, 2025
387a073
Try other DefineConst delimiter
ViktorHofer Aug 11, 2025
390fa4b
Add projects to solution files
ViktorHofer Aug 11, 2025
d2d43ce
Merge branch 'main' into MoveRoslynAnalyzersToSdk
ViktorHofer Aug 14, 2025
8049330
Merge branch 'main' into MoveRoslynAnalyzersToSdk
ViktorHofer Aug 14, 2025
49da7ff
Fix source-build
ViktorHofer Aug 14, 2025
7aded0a
Validate NetAnalyzers offline only
ViktorHofer Aug 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 4 additions & 3 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
<PackageProjectUrl>https://github.com/dotnet/sdk</PackageProjectUrl>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<LangVersion>Preview</LangVersion>
<LangVersion Condition="'$(Language)' == 'VB'">16</LangVersion>
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
<DebugSymbols>true</DebugSymbols>
<!-- Default to all packages generating a corresponding symbol package -->
Expand All @@ -63,9 +64,9 @@
<UseSharedCompilation Condition="'$(DotNetBuildSourceOnly)' == 'true'">false</UseSharedCompilation>
<DisableImplicitPackageTargetFallback>true</DisableImplicitPackageTargetFallback>

<DefineConstants Condition="'$(ContinuousIntegrationBuild)' == 'true'">$(DefineConstants);CI_BUILD</DefineConstants>
<DefineConstants Condition="'$(OfficialBuilder)' == 'Microsoft'">$(DefineConstants);MICROSOFT_ENABLE_TELEMETRY</DefineConstants>
<DefineConstants Condition="'$(DotNetBuildSourceOnly)' == 'true'">$(DefineConstants);DOT_NET_BUILD_FROM_SOURCE</DefineConstants>
<DefineConstants Condition="'$(ContinuousIntegrationBuild)' == 'true'">$(DefineConstants),CI_BUILD</DefineConstants>
<DefineConstants Condition="'$(OfficialBuilder)' == 'Microsoft'">$(DefineConstants),MICROSOFT_ENABLE_TELEMETRY</DefineConstants>
<DefineConstants Condition="'$(DotNetBuildSourceOnly)' == 'true'">$(DefineConstants),DOT_NET_BUILD_FROM_SOURCE</DefineConstants>

<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
Expand Down
1 change: 1 addition & 0 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'
and $(MicrosoftNETCoreAppRefPackageVersion.StartsWith('$(_TargetFrameworkVersionWithoutV)'))
and '$(MSBuildProjectName)' != 'sdk-tasks'
and '$(MSBuildProjectName)' != 'GenerateDocumentationAndConfigFiles'
and ('$(DotNetBuild)' != 'true' or '$(PackAsToolShimRuntimeIdentifiers)' == '')">
<FrameworkReference
Update="Microsoft.NETCore.App"
Expand Down
14 changes: 13 additions & 1 deletion Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,32 @@
<PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="$(MicrosoftAspNetCoreTestHostPackageVersion)" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="$(MicrosoftBclAsyncInterfacesPackageVersion)" />
<PackageVersion Include="Microsoft.Build.NuGetSdkResolver" Version="$(MicrosoftBuildNuGetSdkResolverPackageVersion)" />

<!-- roslyn dependencies -->
<PackageVersion Include="Microsoft.CodeAnalysis" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzer.Testing" Version="$(MicrosoftCodeAnalysisAnalyzerTestingVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.BuildClient" Version="$(MicrosoftCodeAnalysisBuildClientVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="$(MicrosoftCodeAnalysisCSharpPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Features" Version="$(MicrosoftCodeAnalysisCSharpPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="$(MicrosoftCodeAnalysisCSharpWorkspacesPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Features" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="$(MicrosoftCodeAnalysisNetAnalyzersVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="$(MicrosoftCodeAnalysisPublicApiAnalyzersVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Razor.Tooling.Internal" Version="$(MicrosoftCodeAnalysisRazorToolingInternalVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.CodeStyle" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Features" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="$(MicrosoftCodeAnalysisPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="$(MicrosoftCodeAnalysisWorkspacesMSBuildPackageVersion)" />

<!-- roslyn-sdk dependencies-->
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing" Version="1.1.2" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.CodeRefactoring.Testing" Version="1.1.2" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.CodeFix.Testing" Version="1.1.2" />
<PackageVersion Include="Microsoft.CodeAnalysis.VisualBasic.CodeRefactoring.Testing" Version="1.1.2" />
Comment on lines +40 to +43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these versions be hard-coded or should they flow from some repo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be hardcoded. We don't flow from roslyn-sdk.


<PackageVersion Include="Microsoft.Css.Parser" Version="$(MicrosoftCssParserVersion)" />
<PackageVersion Include="Microsoft.DiaSymReader" Version="$(MicrosoftDiaSymReaderVersion)" />
<PackageVersion Include="Microsoft.Deployment.DotNet.Releases" Version="$(MicrosoftDeploymentDotNetReleasesVersion)" />
Expand Down Expand Up @@ -107,6 +117,7 @@
<PackageVersion Include="System.CodeDom" Version="$(SystemCodeDomPackageVersion)" />
<PackageVersion Include="System.CommandLine" Version="$(SystemCommandLineVersion)" />
<PackageVersion Include="System.CommandLine.NamingConventionBinder" Version="$(SystemCommandLineNamingConventionBinderVersion)" />
<PackageVersion Include="System.ComponentModel.Composition" Version="$(SystemComponentModelCompositionPackageVersion)" />
<PackageVersion Include="System.Composition.AttributedModel" Version="$(SystemCompositionAttributedModelPackageVersion)" />
<PackageVersion Include="System.Composition.Convention" Version="$(SystemCompositionConventionPackageVersion)" />
<PackageVersion Include="System.Composition.Hosting" Version="$(SystemCompositionHostingPackageVersion)" />
Expand All @@ -130,6 +141,7 @@
<PackageVersion Include="Valleysoft.DockerCredsProvider" Version="2.2.4" />
<PackageVersion Include="xunit" Version="$(XUnitVersion)" />
<PackageVersion Include="Xunit.Combinatorial" Version="$(XunitCombinatorialVersion)" />
<PackageVersion Include="xunit.assert" Version="$(XUnitVersion)" Condition="'$(IsTestProject)' != 'true'" />
<PackageVersion Include="xunit.console" Version="$(XUnitVersion)" />
</ItemGroup>

Expand Down
3 changes: 3 additions & 0 deletions eng/Version.Details.props
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ This file should be imported by eng/Versions.props
<NuGetVersioningPackageVersion>7.0.0-preview.1.609</NuGetVersioningPackageVersion>
<SystemCodeDomPackageVersion>10.0.0-rc.1.25411.109</SystemCodeDomPackageVersion>
<SystemCommandLinePackageVersion>2.0.0-rc.1.25411.109</SystemCommandLinePackageVersion>
<SystemComponentModelCompositionPackageVersion>10.0.0-preview.7.25377.103</SystemComponentModelCompositionPackageVersion>
<SystemCompositionAttributedModelPackageVersion>10.0.0-rc.1.25411.109</SystemCompositionAttributedModelPackageVersion>
<SystemCompositionConventionPackageVersion>10.0.0-rc.1.25411.109</SystemCompositionConventionPackageVersion>
<SystemCompositionHostingPackageVersion>10.0.0-rc.1.25411.109</SystemCompositionHostingPackageVersion>
Expand Down Expand Up @@ -259,6 +260,8 @@ This file should be imported by eng/Versions.props
<NuGetVersioningVersion>$(NuGetVersioningPackageVersion)</NuGetVersioningVersion>
<SystemCodeDomVersion>$(SystemCodeDomPackageVersion)</SystemCodeDomVersion>
<SystemCommandLineVersion>$(SystemCommandLinePackageVersion)</SystemCommandLineVersion>
<SystemComponentModelCompositionVersion>$(SystemComponentModelCompositionPackageVersion)</SystemComponentModelCompositionVersion>
<SystemComponentModelCompositionVersion>$(SystemComponentModelCompositionPackageVersion)</SystemComponentModelCompositionVersion>
<SystemCompositionAttributedModelVersion>$(SystemCompositionAttributedModelPackageVersion)</SystemCompositionAttributedModelVersion>
<SystemCompositionConventionVersion>$(SystemCompositionConventionPackageVersion)</SystemCompositionConventionVersion>
<SystemCompositionHostingVersion>$(SystemCompositionHostingPackageVersion)</SystemCompositionHostingVersion>
Expand Down
8 changes: 4 additions & 4 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,10 @@
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>520c71b5277fc1f72dbec14da03ca55205d6c8e5</Sha>
</Dependency>
<Dependency Name="System.ComponentModel.Composition" Version="10.0.0-preview.7.25377.103">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>87e4c823cc62a13a3e8afbddc78bf718971f376c</Sha>
</Dependency>
<Dependency Name="System.Formats.Asn1" Version="10.0.0-rc.1.25411.109">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>520c71b5277fc1f72dbec14da03ca55205d6c8e5</Sha>
Expand Down Expand Up @@ -383,10 +387,6 @@
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>520c71b5277fc1f72dbec14da03ca55205d6c8e5</Sha>
</Dependency>
<Dependency Name="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.0-preview.25411.109">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>520c71b5277fc1f72dbec14da03ca55205d6c8e5</Sha>
</Dependency>
<Dependency Name="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="5.0.0-2.25411.109">
<Uri>https://github.com/dotnet/dotnet</Uri>
<Sha>520c71b5277fc1f72dbec14da03ca55205d6c8e5</Sha>
Expand Down
3 changes: 2 additions & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
<WebDeploymentPackageVersion>4.0.5</WebDeploymentPackageVersion>
<SystemCommandLineVersion>2.0.0-rc.1.25377.103</SystemCommandLineVersion>
<SystemCommandLineNamingConventionBinderVersion>2.0.0-beta5.25279.2</SystemCommandLineNamingConventionBinderVersion>
<MicrosoftCodeAnalysisAnalyzerTestingVersion>1.1.2-beta1.22216.1</MicrosoftCodeAnalysisAnalyzerTestingVersion>
<MicrosoftCodeAnalysisAnalyzerTestingVersion>1.1.2</MicrosoftCodeAnalysisAnalyzerTestingVersion>
<MicrosoftCodeAnalysisVersionForNetAnalyzers>3.11.0</MicrosoftCodeAnalysisVersionForNetAnalyzers>
<MicrosoftVisualBasicVersion>10.3.0</MicrosoftVisualBasicVersion>
<MicrosoftVisualStudioSetupConfigurationInteropVersion>3.2.2146</MicrosoftVisualStudioSetupConfigurationInteropVersion>
<MicrosoftWindowsCsWin32PackageVersion>0.3.49-beta</MicrosoftWindowsCsWin32PackageVersion>
Expand Down
20 changes: 20 additions & 0 deletions sdk.slnx
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,26 @@
<Project Path="src/Layout/VS.Redist.Common.NetCore.Templates/VS.Redist.Common.NetCore.Templates.proj" Type="C#" />
<Project Path="src/Layout/VS.Redist.Common.NetCore.Toolset/VS.Redist.Common.NetCore.Toolset.proj" Type="C#" />
</Folder>
<Folder Name="/src/NetAnalyzers/" />
<Folder Name="/src/NetAnalyzers/src/">
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.CSharp.NetAnalyzers/Microsoft.CodeAnalysis.CSharp.NetAnalyzers.csproj" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Setup/Microsoft.CodeAnalysis.NetAnalyzers.Setup.csproj" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.csproj" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers/Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.vbproj" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Utilities/Compiler.CSharp/Analyzer.CSharp.Utilities.shproj" Id="be5fe32c-da73-4ec5-809e-e11b05aca398" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Utilities/Compiler/Analyzer.Utilities.shproj" Id="ec946164-1e17-410b-b7d9-7de7e6268d63" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Utilities/FlowAnalysis/FlowAnalysis.Utilities.shproj" Id="fcb56cba-fa35-46a8-86b7-bae5433197d9" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/src/Utilities/Workspaces/Workspaces.Utilities.shproj" Id="99f594b1-3916-471d-a761-a6731fc50e9a" />
</Folder>
<Folder Name="/src/NetAnalyzers/tests/">
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests/Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/tests/Test.Utilities/Test.Utilities.csproj" />
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/tests/TestReferenceAssembly/TestReferenceAssembly.csproj" />
</Folder>
<Folder Name="/src/NetAnalyzers/tools/">
<Project Path="src/Microsoft.CodeAnalysis.NetAnalyzers/tools/GenerateDocumentationAndConfigFiles/GenerateDocumentationAndConfigFiles.csproj" />
</Folder>
<Folder Name="/src/RazorSdk/" />
<Folder Name="/src/RazorSdk/Sdk/">
<File Path="src/RazorSdk/Sdk/Sdk.props" />
Expand Down
4 changes: 4 additions & 0 deletions source-build.slnf
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
"src\\Layout\\redist\\tools\\tool_msbuild.csproj",
"src\\Layout\\redist\\tools\\tool_nuget.csproj",
"src\\Microsoft.DotNet.TemplateLocator\\Microsoft.DotNet.TemplateLocator.csproj",
"src\\Microsoft.CodeAnalysis.NetAnalyzers\\src\\Microsoft.CodeAnalysis.CSharp.NetAnalyzers\\Microsoft.CodeAnalysis.CSharp.NetAnalyzers.csproj",
"src\\Microsoft.CodeAnalysis.NetAnalyzers\\src\\Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers\\Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.vbproj",
"src\\Microsoft.CodeAnalysis.NetAnalyzers\\src\\Microsoft.CodeAnalysis.NetAnalyzers\\Microsoft.CodeAnalysis.NetAnalyzers.csproj",
"src\\Microsoft.CodeAnalysis.NetAnalyzers\\src\\Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj",
"src\\Microsoft.Win32.Msi\\Microsoft.Win32.Msi.csproj",
"src\\RazorSdk\\Tasks\\Microsoft.NET.Sdk.Razor.Tasks.csproj",
"src\\RazorSdk\\Tool\\Microsoft.NET.Sdk.Razor.Tool.csproj",
Expand Down
1 change: 1 addition & 0 deletions src/Compatibility/Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<!-- We pin the code analysis version when not in source build as we need to support running on older
SDKs when the OOB package is used. -->
<PackageVersion Update="Microsoft.CodeAnalysis.CSharp" Version="4.4.0" />
<PackageVersion Update="Microsoft.CodeAnalysis.Common" Version="4.4.0" />
</ItemGroup>

</Project>
3 changes: 2 additions & 1 deletion src/Layout/redist/redist.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
<PackageReference Include="Microsoft.TestPlatform.Build" />
<PackageReference Condition=" '$(DotNetBuildSourceOnly)' != 'true' " Include="NuGet.Localization" />
<PackageReference Include="NuGet.ProjectModel" />
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" ExcludeAssets="All" GeneratePathProperty="true" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" ExcludeAssets="All" GeneratePathProperty="true" />
<PackageReference Include="Microsoft.CodeAnalysis.VisualBasic.CodeStyle" ExcludeAssets="All" GeneratePathProperty="true" />
<PackageReference Include="Microsoft.FSharp.Compiler" ExcludeAssets="All" GeneratePathProperty="true" />
Expand Down Expand Up @@ -71,6 +70,8 @@
<ProjectReference Include="$(RepoRoot)src\BuiltInTools\dotnet-format\dotnet-format.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" Private="false" />

<ProjectReference Include="$(RepoRoot)template_feed\*\*.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" Private="false" />

<ProjectReference Include="$(RepoRoot)src\Microsoft.CodeAnalysis.NetAnalyzers\src\Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj" ReferenceOutputAssembly="false" SkipGetTargetFrameworkProperties="true" Private="false" />
</ItemGroup>

<ItemGroup Condition="'$(OS)' == 'Windows_NT'">
Expand Down
Loading
Loading