Skip to content

[release/8.0.1xx] Update Microsoft.NET.Build.Tests that depend on System.ValueTuple to arget netstandard2.0 #49659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

[release/8.0.1xx] Update Microsoft.NET.Build.Tests that depend on System.ValueTuple to arget netstandard2.0 #49659

merged 1 commit into from
Jul 7, 2025

Conversation

@SimonZhao888
Copy link
Member

@SimonZhao888 SimonZhao888 commented Jul 4, 2025

Update Microsoft.NET.Build.Tests that depend on System.ValueTuple to arget netstandard2.0

@SimonZhao888 SimonZhao888 force-pushed the dev/Simon/FixGivenThatWeWantToBuildALibraryIssue branch from 3a04719 to e63b89e Compare July 4, 2025 08:41
@SimonZhao888 SimonZhao888 marked this pull request as ready for review July 4, 2025 09:55
@SimonZhao888 SimonZhao888 mentioned this pull request Jul 4, 2025
Merged
@build-analysis build-analysis bot mentioned this pull request Jul 4, 2025
Open
@SimonZhao888
Copy link
Member Author

SimonZhao888 commented Jul 7, 2025

Container registry issues.

@SimonZhao888
Copy link
Member Author

SimonZhao888 commented Jul 7, 2025 •
edited
Loading

@joeloff, @MiYanni, could you please review this PR, this PR will fix test failure in GivenThatWeWantToXXXX?
After this PR completed, backport it to release/8.0.3xx and release/8.0.4xx, these 2 branches also have the same test failure of GivenThatWeWantToXXXX.

@SimonZhao888 SimonZhao888 mentioned this pull request Jul 7, 2025
Merged
@nagilson
Copy link
Member

nagilson commented Jul 7, 2025

The ubuntu leg failed due to container registry issues. Rerunning and hope to merge. Thank you!

@nagilson nagilson enabled auto-merge July 7, 2025 21:43
@nagilson
Copy link
Member

nagilson commented Jul 7, 2025

/backport to release/8.0.3xx

@nagilson
Copy link
Member

nagilson commented Jul 7, 2025

/backport to release/8.0.4xx

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/16128553919

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/16128556012

This was referenced Jul 7, 2025
Closed
Closed
@nagilson
Copy link
Member

nagilson commented Jul 7, 2025

Thank you for this 😉

@nagilson nagilson added Area-Containers Related to dotnet SDK containers functionality needs team triage Requires a full team discussion labels Jul 7, 2025
@nagilson nagilson merged commit 37f56fa into dotnet:release/8.0.1xx Jul 7, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagilson nagilson nagilson approved these changes

@marcpopMSFT marcpopMSFT Awaiting requested review from marcpopMSFT

@joeloff joeloff Awaiting requested review from joeloff

@MiYanni MiYanni Awaiting requested review from MiYanni

Assignees

No one assigned

Labels

Area-Containers Related to dotnet SDK containers functionality needs team triage Requires a full team discussion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonZhao888 @nagilson