Skip to content

Conversation

@dtivel
Copy link
Contributor

@dtivel dtivel commented Jun 5, 2025

Progress on #49267.

This is the May 2025 update from the Microsoft Trusted Root Program team.

I also updated test baselines.

CC @aortiz-msft, @dotnet/nuget-team

Copilot AI review requested due to automatic review settings June 5, 2025 17:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the trusted roots configuration as part of the May 2025 CTL update, including changes to test baselines and certificate data.

  • Adds new certificate fingerprint entries for IdenTrust Commercial Root CA 1, AAA Certificate Services, and GlobalSign Root CA in timestamping tests.
  • Adds a matching IdenTrust Commercial Root CA 1 entry in the code signing tests.
  • Introduces a new certificate block in the trusted roots PEM file to support the updated CTL.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/trustedroots.Tests/GivenTimestampingCtlFile.cs Added new InlineData entries for additional certificate fingerprints.
test/trustedroots.Tests/GivenCodeSigningCtlFile.cs Introduced a new InlineData entry to include IdenTrust Commercial Root CA 1.
src/Layout/redist/trustedroots/timestampctl.pem Inserted a new certificate block to update the trusted certificate list.

@dtivel dtivel merged commit 41dcb3a into main Jun 5, 2025
31 checks passed
@dtivel dtivel deleted the dtivel/2025-05-ctl branch June 5, 2025 23:25
dtivel added a commit that referenced this pull request Jun 5, 2025
dtivel added a commit that referenced this pull request Jun 5, 2025
dtivel added a commit that referenced this pull request Jun 5, 2025
dtivel added a commit that referenced this pull request Jun 5, 2025
dtivel added a commit that referenced this pull request Jun 5, 2025
marcpopMSFT pushed a commit that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants