Skip to content

Skip CanFilterAuthor_WithoutName test to unblock main #49124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Skip CanFilterAuthor_WithoutName test to unblock main #49124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f2807a
Skip CanFilterAuthor_WithoutName test to unblock main
May 23, 2025
a05a8c3
Suppress xUnit1004 rule for skipped test
May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,9 @@ public void CanFilterAuthor(string testCase)
Assert.True(AtLeastOneRowIsNotEmpty(tableOutput, "Downloads"), "'Downloads' column contains empty values");
}

[Theory]
#pragma warning disable xUnit1004
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")]
Copy link

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a brief skip reason alongside the URL, e.g., Skip = "Skipped due to issue #49123: incorrect author filtering" to clarify why the test is disabled.

Suggested change
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123: Skipped due to issue #49123: incorrect author filtering")]

Copilot uses AI. Check for mistakes.
#pragma warning restore xUnit1004
[InlineData("--search --columns author --author micro")]
[InlineData("search --columns author --author micro")]
public void CanFilterAuthor_WithoutName(string testCase)
Expand Down
Loading