Change ci.yml -> sb-ci.yml #48953
Merged
Change ci.yml -> sb-ci.yml #48953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
May 14, 2025
This allows us to repoint the SB pipeline at this YAML file, meaning that we can manage triggers for UB, which uses ci.yml, via YAML files rather than the UI. Updated comments to reflect where this file will be used.
ViktorHofer
approved these changes
May 14, 2025
MichaelSimons
approved these changes
May 14, 2025
| - main | ||
| - release/* | ||
| - internal/release/* | ||
|
|
Member
There was a problem hiding this comment.
Don't we also need to define a PR trigger for SB? e.g. for PR: ultralite build.
Member
Author
There was a problem hiding this comment.
I don't think so? The pipelines that use ci.yml are not running any PRs.
Member
There was a problem hiding this comment.
It is possible we would want to test something e2e in the VMR for servicing.
Member
Author
There was a problem hiding this comment.
✅ Pipeline 'dotnet-source-build-lite' uses 'eng/pipelines/ci.yml'
✅ Pipeline 'dotnet-source-build' uses 'eng/pipelines/ci.yml'
✅ Pipeline 'dotnet-unified-build' uses 'eng/pipelines/ci.yml'
Member
Author
There was a problem hiding this comment.
And source-built-lite goes away, correct?
Member
There was a problem hiding this comment.
You are right. I forgot we have a separate pr.yml.
MichaelSimons
approved these changes
May 14, 2025
mmitche
added a commit
to mmitche/sdk
that referenced
this pull request
May 14, 2025
mmitche
added a commit
to mmitche/sdk
that referenced
this pull request
May 14, 2025
mmitche
added a commit
that referenced
this pull request
May 14, 2025
mmitche
added a commit
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to repoint the SB pipeline at this YAML file, meaning that we can manage triggers for UB, which uses ci.yml, via YAML files rather than the UI. Updated comments to reflect where this file will be used.